refactor(Gradle): Use (incubating) simple property assigment

Make use of syntactic sugar to simplify property assign, see [1].

[1]: https://docs.gradle.org/8.2/release-notes.html#simple-property-assignment-in-kotlin-dsl-enabled-by-default

Signed-off-by: Sebastian Schuberth <[email protected]>

Author: sschuberth

buildSrc/src/main/kotlin/ort-application-conventions.gradle.kts

@@ -41,12 +41,12 @@ application {
 }
 
 graalvmNative {
-    toolchainDetection.set(true)
+    toolchainDetection = true
 
     // For options see https://graalvm.github.io/native-build-tools/latest/gradle-plugin.html.
     binaries {
         named("main") {
-            imageName.set(application.applicationName)
+            imageName = application.applicationName
 
             val initializeAtBuildTime = listOf(
                 "ch.qos.logback.classic.Level",
@@ -66,7 +66,7 @@ graalvmNative {
     }
 
     metadataRepository {
-        enabled.set(true)
+        enabled = true
     }
 }
 

buildSrc/src/main/kotlin/ort-kotlin-conventions.gradle.kts

@@ -69,7 +69,7 @@ testing {
         register<JvmTestSuite>("funTest") {
             sources {
                 kotlin {
-                    testType.set(TestSuiteType.FUNCTIONAL_TEST)
+                    testType = TestSuiteType.FUNCTIONAL_TEST
                 }
             }
         }
@@ -125,7 +125,7 @@ val mergeDetektReports = if (rootProject.tasks.findByName(mergeDetektReportsTask
     rootProject.tasks.named<ReportMergeTask>(mergeDetektReportsTaskName)
 } else {
     rootProject.tasks.register<ReportMergeTask>(mergeDetektReportsTaskName) {
-        output.set(rootProject.buildDir.resolve("reports/detekt/merged.sarif"))
+        output = rootProject.buildDir.resolve("reports/detekt/merged.sarif")
     }
 }
 
@@ -135,16 +135,16 @@ tasks.withType<Detekt> detekt@{
     dependsOn(":detekt-rules:assemble")
 
     reports {
-        html.required.set(false)
+        html.required = false
 
         // TODO: Enable this once https://github.com/detekt/detekt/issues/5034 is resolved and use the merged
         //       Markdown file as a GitHub Action job summary, see
         //       https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/.
-        md.required.set(false)
+        md.required = false
 
-        sarif.required.set(true)
-        txt.required.set(false)
-        xml.required.set(false)
+        sarif.required = true
+        txt.required = false
+        xml.required = false
     }
 
     mergeDetektReports.configure {
@@ -176,7 +176,7 @@ tasks.withType<KotlinCompile>().configureEach {
 }
 
 val sourcesJar by tasks.registering(Jar::class) {
-    archiveClassifier.set("sources")
+    archiveClassifier = "sources"
     from(sourceSets.main.get().allSource)
 }
 
@@ -186,7 +186,7 @@ tasks.register<Jar>("docsHtmlJar") {
 
     dependsOn(tasks.dokkatooGeneratePublicationHtml)
     from(tasks.dokkatooGeneratePublicationHtml.flatMap { it.outputDirectory })
-    archiveClassifier.set("htmldoc")
+    archiveClassifier = "htmldoc"
 }
 
 val docsJavadocJar by tasks.registering(Jar::class) {
@@ -195,7 +195,7 @@ val docsJavadocJar by tasks.registering(Jar::class) {
 
     dependsOn(tasks.dokkatooGeneratePublicationJavadoc)
     from(tasks.dokkatooGeneratePublicationJavadoc.flatMap { it.outputDirectory })
-    archiveClassifier.set("javadoc")
+    archiveClassifier = "javadoc"
 }
 
 tasks.withType<Test>().configureEach {
@@ -253,7 +253,7 @@ tasks.named("check") {
 tasks.named<JacocoReport>("jacocoTestReport") {
     reports {
         // Enable XML in addition to HTML for CI integration.
-        xml.required.set(true)
+        xml.required = true
     }
 }
 
@@ -266,7 +266,7 @@ tasks.register<JacocoReport>("jacocoFunTestReport") {
 
     reports {
         // Enable XML in addition to HTML for CI integration.
-        xml.required.set(true)
+        xml.required = true
     }
 }
 
@@ -292,16 +292,16 @@ configure<PublishingExtension> {
             pom {
                 licenses {
                     license {
-                        name.set("Apache-2.0")
-                        url.set("https://www.apache.org/licenses/LICENSE-2.0")
+                        name = "Apache-2.0"
+                        url = "https://www.apache.org/licenses/LICENSE-2.0"
                     }
                 }
 
                 scm {
-                    connection.set("scm:git:https://github.com/oss-review-toolkit/ort.git")
-                    developerConnection.set("scm:git:[email protected]:oss-review-toolkit/ort.git")
-                    tag.set(version.toString())
-                    url.set("https://github.com/oss-review-toolkit/ort")
+                    connection = "scm:git:https://github.com/oss-review-toolkit/ort.git"
+                    developerConnection = "scm:git:[email protected]:oss-review-toolkit/ort.git"
+                    tag = version.toString()
+                    url = "https://github.com/oss-review-toolkit/ort"
                 }
             }
         }

buildSrc/src/main/kotlin/ort-plugins-conventions.gradle.kts

@@ -52,16 +52,16 @@ configure<PublishingExtension> {
             pom {
                 licenses {
                     license {
-                        name.set("Apache-2.0")
-                        url.set("https://www.apache.org/licenses/LICENSE-2.0")
+                        name = "Apache-2.0"
+                        url = "https://www.apache.org/licenses/LICENSE-2.0"
                     }
                 }
 
                 scm {
-                    connection.set("scm:git:https://github.com/oss-review-toolkit/ort.git")
-                    developerConnection.set("scm:git:[email protected]:oss-review-toolkit/ort.git")
-                    tag.set(version.toString())
-                    url.set("https://github.com/oss-review-toolkit/ort")
+                    connection = "scm:git:https://github.com/oss-review-toolkit/ort.git"
+                    developerConnection = "scm:git:[email protected]:oss-review-toolkit/ort.git"
+                    tag = version.toString()
+                    url = "https://github.com/oss-review-toolkit/ort"
                 }
             }
         }

cli/build.gradle.kts

@@ -24,7 +24,7 @@ plugins {
 
 application {
     applicationName = "ort"
-    mainClass.set("org.ossreviewtoolkit.cli.OrtMainKt")
+    mainClass = "org.ossreviewtoolkit.cli.OrtMainKt"
 }
 
 dependencies {

helper-cli/build.gradle.kts

@@ -24,7 +24,7 @@ plugins {
 
 application {
     applicationName = "orth"
-    mainClass.set("org.ossreviewtoolkit.helper.HelperMainKt")
+    mainClass = "org.ossreviewtoolkit.helper.HelperMainKt"
 }
 
 dependencies {

plugins/package-managers/gradle-plugin/build.gradle.kts

@@ -43,7 +43,7 @@ tasks.register<Jar>("fatJar") {
     description = "Creates a fat JAR that includes all required runtime dependencies."
     group = "Build"
 
-    archiveClassifier.set("fat")
+    archiveClassifier = "fat"
 
     from(sourceSets.main.get().output)
     dependsOn(configurations.runtimeClasspath)