test(model): Increase test coverage for declared license mappings

Relates to #10759.

Signed-off-by: Sebastian Schuberth <[email protected]>

Author: sschuberth

model/src/main/kotlin/OrtResult.kt

@@ -695,7 +695,7 @@ private val logger = loggerOf(MethodHandles.lookup().lookupClass())
  * given [curations] to the packages they apply to. The given [curations] must be ordered highest-priority-first, which
  * is the inverse order of their application.
  */
-private fun applyPackageCurations(
+internal fun applyPackageCurations(
     packages: Collection<Package>,
     curations: List<PackageCuration>
 ): Set<CuratedPackage> {

model/src/test/kotlin/OrtResultTest.kt

@@ -26,6 +26,7 @@ import io.kotest.matchers.collections.containExactly
 import io.kotest.matchers.collections.containExactlyInAnyOrder
 import io.kotest.matchers.collections.haveSize
 import io.kotest.matchers.collections.shouldContain
+import io.kotest.matchers.collections.shouldContainExactly
 import io.kotest.matchers.collections.shouldHaveSingleElement
 import io.kotest.matchers.collections.shouldNotContain
 import io.kotest.matchers.should
@@ -46,9 +47,44 @@ import org.ossreviewtoolkit.model.config.RepositoryConfiguration
 import org.ossreviewtoolkit.model.config.Resolutions
 import org.ossreviewtoolkit.model.config.RuleViolationResolution
 import org.ossreviewtoolkit.model.config.RuleViolationResolutionReason
+import org.ossreviewtoolkit.utils.ort.ProcessedDeclaredLicense
+import org.ossreviewtoolkit.utils.spdx.toSpdx
 import org.ossreviewtoolkit.utils.test.readOrtResult
 
 class OrtResultTest : WordSpec({
+    "applyPackageCurations()" should {
+        "apply a single package curation with a declared license mapping" {
+            val licenseUrl = "https://www.nuget.org/packages/CommandLineParser/2.9.1/license"
+
+            val pkg = Package.EMPTY.copy(
+                declaredLicenses = setOf(licenseUrl)
+            )
+
+            val curation = PackageCuration(
+                id = pkg.id,
+                data = PackageCurationData(
+                    declaredLicenseMapping = mapOf(
+                        licenseUrl to "MIT".toSpdx()
+                    )
+                )
+            )
+
+            applyPackageCurations(setOf(pkg), listOf(curation)).shouldContainExactly(
+                CuratedPackage(
+                    metadata = Package.EMPTY.copy(
+                        declaredLicenses = setOf(licenseUrl),
+                        declaredLicensesProcessed = ProcessedDeclaredLicense(
+                            spdxExpression = "MIT".toSpdx(),
+                            mapped = mapOf(licenseUrl to "MIT".toSpdx()),
+                            unmapped = emptySet()
+                        )
+                    ),
+                    curations = listOf(curation.data)
+                )
+            )
+        }
+    }
+
     "getDependencies()" should {
         "be able to get all direct dependencies of a package" {
             val ortResult = readOrtResult("/sbt-multi-project-example-expected-output.yml")

model/src/test/kotlin/PackageCurationTest.kt

@@ -270,6 +270,21 @@ class PackageCurationTest : WordSpec({
             curation.isApplicable(pkgVersionInsideRange.id) shouldBe true
             curation.isApplicable(pkgVersionOutsideRange.id) shouldBe false
         }
+
+        "work with URLs as keys for declared license mappings" {
+            val licenseUrl = "https://www.nuget.org/packages/CommandLineParser/2.9.1/license"
+
+            val pkg = Package.EMPTY.copy(declaredLicenses = setOf(licenseUrl))
+
+            val curation = PackageCuration(
+                id = pkg.id,
+                data = PackageCurationData(declaredLicenseMapping = mapOf(licenseUrl to "MIT".toSpdx()))
+            )
+
+            val curatedPkg = curation.apply(pkg.toCuratedPackage())
+
+            curatedPkg.metadata.declaredLicensesProcessed.allLicenses.shouldContainExactly("MIT")
+        }
     }
 
     "Applying multiple curations" should {