chore: Shorten .also { it. one-liners with apply

Signed-off-by: Sebastian Schuberth <[email protected]>

Author: sschuberth

buildSrc/src/main/kotlin/GeneratePluginDocsTask.kt

@@ -62,7 +62,7 @@ abstract class GeneratePluginDocsTask : DefaultTask() {
 
     private fun generatePluginDocs(pluginType: String) {
         val plugins = inputFiles.filter { it.invariantSeparatorsPath.contains("plugins/$pluginType") }
-        val dir = outputDirectory.resolve(pluginType).also { it.mkdirs() }
+        val dir = outputDirectory.resolve(pluginType).apply { mkdirs() }
 
         logger.lifecycle("Found ${plugins.count()} ${pluginType.replace('-', ' ')}.")
 

plugins/package-managers/maven/src/test/kotlin/MavenTest.kt

@@ -32,15 +32,15 @@ class MavenTest : WordSpec({
         "filter out Tycho definition files" {
             val tychoProjectDir1 = tempdir()
             tychoProjectDir1.addTychoExtension()
-            val tychoDefinitionFile1 = tychoProjectDir1.resolve("pom.xml").also { it.writeText("pom-tycho1") }
+            val tychoDefinitionFile1 = tychoProjectDir1.resolve("pom.xml").apply { writeText("pom-tycho1") }
             val tychoSubProjectDir = tychoProjectDir1.resolve("subproject")
             val tychoSubModule = tychoSubProjectDir.resolve("pom.xml")
             val tychoProjectDir2 = tempdir()
             tychoProjectDir2.addTychoExtension()
-            val tychoDefinitionFile2 = tychoProjectDir2.resolve("pom.xml").also { it.writeText("pom-tycho2") }
+            val tychoDefinitionFile2 = tychoProjectDir2.resolve("pom.xml").apply { writeText("pom-tycho2") }
 
             val mavenProjectDir = tempdir()
-            val mavenDefinitionFile = mavenProjectDir.resolve("pom.xml").also { it.writeText("pom-maven") }
+            val mavenDefinitionFile = mavenProjectDir.resolve("pom.xml").apply { writeText("pom-maven") }
             val mavenSubProjectDir = mavenProjectDir.resolve("subproject")
             val mavenSubModule = mavenSubProjectDir.resolve("pom.xml")
 

plugins/package-managers/maven/src/test/kotlin/tycho/TargetHandlerTest.kt

@@ -101,9 +101,9 @@ private fun TestConfiguration.createTargetHandlerWithTargetFiles(): TargetHandle
     val root = tempdir()
     val targetFile1 = File("src/test/assets/tycho.target")
     val targetFile2 = File("src/test/assets/tycho.other.target")
-    val module1 = root.resolve("module1").also { it.mkdirs() }
-    val module2 = root.resolve("module2").also { it.mkdirs() }
-    val subModule = module2.resolve("subModule.target").also { it.mkdirs() }
+    val module1 = root.resolve("module1").apply { mkdirs() }
+    val module2 = root.resolve("module2").apply { mkdirs() }
+    val subModule = module2.resolve("subModule.target").apply { mkdirs() }
     targetFile1.copyTo(module1.resolve("tycho.target"))
     targetFile2.copyTo(subModule.resolve("tycho.other.target"))
 

plugins/package-managers/maven/src/test/kotlin/tycho/TychoTest.kt

@@ -79,15 +79,15 @@ class TychoTest : WordSpec({
         "select only Tycho root projects" {
             val tychoProjectDir1 = tempdir()
             tychoProjectDir1.addTychoExtension()
-            val tychoDefinitionFile1 = tychoProjectDir1.resolve("pom.xml").also { it.writeText("pom-tycho1") }
+            val tychoDefinitionFile1 = tychoProjectDir1.resolve("pom.xml").apply { writeText("pom-tycho1") }
             val tychoSubProjectDir = tychoProjectDir1.resolve("subproject")
             val tychoSubModule = tychoSubProjectDir.resolve("pom.xml")
             val tychoProjectDir2 = tempdir()
             tychoProjectDir2.addTychoExtension()
-            val tychoDefinitionFile2 = tychoProjectDir2.resolve("pom.xml").also { it.writeText("pom-tycho2") }
+            val tychoDefinitionFile2 = tychoProjectDir2.resolve("pom.xml").apply { writeText("pom-tycho2") }
 
             val mavenProjectDir = tempdir()
-            val mavenDefinitionFile = mavenProjectDir.resolve("pom.xml").also { it.writeText("pom-maven") }
+            val mavenDefinitionFile = mavenProjectDir.resolve("pom.xml").apply { writeText("pom-maven") }
             val mavenSubProjectDir = mavenProjectDir.resolve("subproject")
             val mavenSubModule = mavenSubProjectDir.resolve("pom.xml")