fix(model): Stop throwing accidentally from an invariant check

The previous implementation of `Identifier.isVersionRange()` returned
true if and only if the version string contained characters hard-coded
to be a version range indicator, see the constant
`IVY_VERSION_RANGE_INDICATORS`. This heuristic returns false positives
for versions which are not a version range, but contain version range
indicators, such as for the package `Crate::wasi:0.13.3+wasi-0.2.2`.
Such false positives in turn make the recently introduced invariant
check in the constructor of `PackageConfiguration` fail accidentally.

Improve the heuristic of `Identifier.isVersionRange()` to fix that.

Signed-off-by: Frank Viernau <[email protected]>

Author: fviernau

model/src/main/kotlin/utils/VersionUtils.kt

@@ -54,7 +54,17 @@ internal fun Identifier.isApplicableIvyVersion(pkgId: Identifier) =
         it.showStackTrace()
     }.getOrDefault(false)
 
-internal fun Identifier.isVersionRange() = IVY_VERSION_RANGE_INDICATORS.any { version.contains(it, ignoreCase = true) }
+internal fun Identifier.isVersionRange(): Boolean {
+    val rangesList = getVersionRange() ?: return false
+    val ranges = rangesList.get().flatten()
+    val rangeVersions = ranges.mapTo(mutableSetOf()) { it.rangeVersion }
+    val isSingleVersion = rangeVersions.size <= 1 && ranges.all { range ->
+        // Determine whether the non-accessible `Range.rangeOperator` is `RangeOperator.EQUALS`.
+        range.toString().startsWith("=")
+    }
+
+    return !isSingleVersion
+}
 
 private fun Identifier.getVersionRange(): RangesList? {
     if (IVY_VERSION_RANGE_INDICATORS.none { version.contains(it, ignoreCase = true) }) return null

model/src/test/kotlin/config/PackageConfigurationTest.kt

@@ -208,5 +208,12 @@ class PackageConfigurationTest : WordSpec({
                 )
             }
         }
+
+        "not throw if a version range with a range indicator is given while having a source artifact URL" {
+            PackageConfiguration(
+                id = Identifier.EMPTY.copy(version = "0.13.3+wasi-0.2.2"),
+                sourceArtifactUrl = "https://host/path/file.zip"
+            )
+        }
     }
 })