Skip to content

Commit 8a8748f

Browse files
Burhan KhanBurhan Khan
authored andcommitted
Addressed the peer review comments. Corrected file names of description.js and dropdowns.js, changed sidebar.js and main.js so that sidebar.js can be exported and main.js can import. Full modularization should be acheived.
1 parent 1f619b3 commit 8a8748f

File tree

5 files changed

+21
-15
lines changed

5 files changed

+21
-15
lines changed

templates/boneset.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
</div>
2323

2424
<div id="sidebar-container"></div>
25-
<script src="sidebar.js"></script>
2625

2726
<div id="editor-view">
2827
<div class="container">

templates/js/main.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,19 @@
11
// js/main.js
22
import { fetchCombinedData } from './api.js';
33
import { populateBonesetDropdown, setupDropdownListeners } from './dropdowns.js';
4+
import { initializeSidebar } from './sidebar.js';
45

56
let combinedData = { bonesets: [], bones: [], subbones: [] };
67

78
document.addEventListener('DOMContentLoaded', async () => {
9+
// Initialize sidebar toggle behavior
10+
initializeSidebar();
11+
12+
// Fetch and render bone data
813
combinedData = await fetchCombinedData();
914
populateBonesetDropdown(combinedData.bonesets);
1015
setupDropdownListeners(combinedData);
1116

12-
// Automatically pre-select the first boneset if available
1317
const boneset = combinedData.bonesets[0];
1418
if (boneset) {
1519
document.getElementById('boneset-select').value = boneset.id;

templates/js/sidebar.js

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
document.addEventListener('DOMContentLoaded', () => {
1+
// js/sidebar.js
2+
export function initializeSidebar() {
23
const toggleButton = document.getElementById('toggle-sidebar');
34
const sidebarContainer = document.getElementById('sidebar-container');
45

5-
// Load the sidebar dynamically if not already loaded
66
async function loadSidebar() {
77
if (!sidebarContainer.innerHTML) {
88
try {
@@ -15,15 +15,18 @@ document.addEventListener('DOMContentLoaded', () => {
1515
}
1616
}
1717

18-
// Toggle sidebar visibility
19-
toggleButton.addEventListener('click', async () => {
20-
await loadSidebar(); // Ensure the sidebar is loaded
21-
const sidebarElement = document.getElementById('sidebar');
18+
if (toggleButton) {
19+
toggleButton.addEventListener('click', async () => {
20+
await loadSidebar(); // Ensure the sidebar is loaded
21+
const sidebarElement = document.getElementById('sidebar');
2222

23-
if (sidebarElement.style.left === '0px') {
24-
sidebarElement.style.left = '-250px'; // Close sidebar
25-
} else {
26-
sidebarElement.style.left = '0px'; // Open sidebar
27-
}
28-
});
29-
});
23+
if (sidebarElement) {
24+
if (sidebarElement.style.left === '0px') {
25+
sidebarElement.style.left = '-250px'; // Close sidebar
26+
} else {
27+
sidebarElement.style.left = '0px'; // Open sidebar
28+
}
29+
}
30+
});
31+
}
32+
}

0 commit comments

Comments
 (0)