refactor: use error codes instead of bare numbers

Author: terriko

test/test_cli.py

@@ -22,6 +22,7 @@
 
 from cve_bin_tool.cli import main
 from cve_bin_tool.cvedb import DISK_LOCATION_DEFAULT
+from cve_bin_tool.error_handler import ERROR_CODES, InsufficientArgs
 from cve_bin_tool.extractor import Extractor
 from cve_bin_tool.version_scanner import VersionScanner
 
@@ -88,37 +89,37 @@ def test_usage(self):
         """Test that the usage returns 0"""
         with pytest.raises(SystemExit) as e:
             main(["cve-bin-tool"])
-        assert e.value.args[0] == 24
+        assert e.value.args[0] == ERROR_CODES[InsufficientArgs]
 
     def test_invalid_file_or_directory(self):
         """Test behaviour with an invalid file/directory"""
         with pytest.raises(SystemExit) as e:
             main(["cve-bin-tool", "non-existant"])
-        assert e.value.args[0] == 21
+        assert e.value.args[0] == ERROR_CODES[FileNotFoundError]
 
     def test_invalid_parameter(self):
         """Test that invalid parmeters exit with expected error code.
-        ArgParse calls sys.exit(2) for all errors """
+        ArgParse calls sys.exit(2) for all errors"""
 
         # no directory specified
         with pytest.raises(SystemExit) as e:
             main(["cve-bin-tool", "--bad-param"])
-        assert e.value.args[0] == 2
+        assert e.value.args[0] == ERROR_CODES[SystemExit]
 
         # bad parameter (but good directory)
         with pytest.raises(SystemExit) as e:
             main(["cve-bin-tool", "--bad-param", self.tempdir])
-        assert e.value.args[0] == 2
+        assert e.value.args[0] == ERROR_CODES[SystemExit]
 
         # worse parameter
         with pytest.raises(SystemExit) as e:
             main(["cve-bin-tool", "--bad-param && cat hi", self.tempdir])
-        assert e.value.args[0] == 2
+        assert e.value.args[0] == ERROR_CODES[SystemExit]
 
         # bad parameter after directory
         with pytest.raises(SystemExit) as e:
             main(["cve-bin-tool", self.tempdir, "--bad-param;cat hi"])
-        assert e.value.args[0] == 2
+        assert e.value.args[0] == ERROR_CODES[SystemExit]
 
     @unittest.skipUnless(LONG_TESTS() > 0, "Skipping long tests")
     def test_update_flags(self):
@@ -136,7 +137,7 @@ def test_update_flags(self):
         )
         with pytest.raises(SystemExit) as e:
             main(["cve-bin-tool", "-u", "whatever", "-n", "json", self.tempdir])
-        assert e.value.args[0] == 2
+        assert e.value.args[0] == ERROR_CODES[SystemExit]
 
     @staticmethod
     def check_exclude_log(caplog, exclude_path, checkers):
@@ -349,11 +350,11 @@ def test_severity(self, capsys, caplog):
         # Check command line parameters - wrong case
         with pytest.raises(SystemExit) as e:
             main(["cve-bin-tool", "-S", "HIGH", self.tempdir])
-        assert e.value.args[0] == 2
+        assert e.value.args[0] == ERROR_CODES[SystemExit]
         # Check command line parameters - wrong option
         with pytest.raises(SystemExit) as e:
             main(["cve-bin-tool", "-S", "ALL", self.tempdir])
-        assert e.value.args[0] == 2
+        assert e.value.args[0] == ERROR_CODES[SystemExit]
 
         my_test_filename = "sevtest.csv"