Archives are extracted by default (previously needed -x)

* Fixes #786 
* Retains -x option for backwards compatibility

Author: anthonyharrison

cve_bin_tool/cli.py

@@ -33,10 +33,7 @@
     EmptyCache,
     ErrorMode,
 )
-from .input_engine import (
-    InputEngine,
-    TriageData,
-)
+from .input_engine import InputEngine, TriageData
 from .log import LOGGER
 from .version import VERSION
 from .version_scanner import VersionScanner
@@ -185,7 +182,7 @@ def main(argv=None):
         "cvss": 0,
         "severity": "low",
         "update": "daily",
-        "extract": False,
+        "extract": True,
         "disable_version_check": False,
         "skips": "",
         "runs": "",

test/config/cve_bin_tool_config.toml

@@ -47,5 +47,5 @@ disable_version_check = false
 # update schedule for NVD database (default: daily)
 update = "daily"
 
-# set true if you want to autoextract archive files. (default: false)
-extract = false
+# set true if you want to autoextract archive files. (default: true)
+extract = true

test/config/cve_bin_tool_config.yaml

@@ -38,5 +38,5 @@ other:
   disable_version_check: false
   # update schedule for NVD database (default: daily)
   update: daily
-  # set true if you want to autoextract archive files. (default: false)
-  extract: false
+  # set true if you want to autoextract archive files. (default: true)
+  extract: true

test/test_cli.py

@@ -55,7 +55,7 @@ def test_binary_curl_7_20_0(self):
 
     def test_no_extraction(self):
         """ Test scanner against curl-7.20.0 rpm with extraction turned off """
-        assert main(["cve-bin-tool", os.path.join(self.tempdir, CURL_7_20_0_RPM)]) == 0
+        assert main(["cve-bin-tool", os.path.join(self.tempdir, CURL_7_20_0_RPM)]) != 0
 
     def test_exclude(self, caplog):
         """ Test that the exclude paths are not scanned """