webapp: add ofg validity api (#2133)

* webapp: make get-all-tests faster

Signed-off-by: David Korczynski <[email protected]>

* add new validity ofg endpoint

Signed-off-by: David Korczynski <[email protected]>

* nit

Signed-off-by: David Korczynski <[email protected]>

* nit

Signed-off-by: David Korczynski <[email protected]>

* nit

Signed-off-by: David Korczynski <[email protected]>

* nit

Signed-off-by: David Korczynski <[email protected]>

* nit

Signed-off-by: David Korczynski <[email protected]>

* nit

Signed-off-by: David Korczynski <[email protected]>

* nit

Signed-off-by: David Korczynski <[email protected]>

---------

Signed-off-by: David Korczynski <[email protected]>

Author: DavidKorczynski

tools/web-fuzzing-introspection/app/webapp/routes.py

@@ -1174,6 +1174,11 @@ def harness_source_and_executable(args):
     if project_name is None:
         return {'result': 'error', 'msg': 'Please provide project name'}
 
+    return _get_harness_source_and_executable(project_name)
+
+
+def _get_harness_source_and_executable(project_name):
+    """Get the binary-to-source pairs of a project."""
     target_project = get_project_with_name(project_name)
     if target_project is None:
         return {'result': 'error', 'msg': 'Project not in the database'}
@@ -1218,7 +1223,7 @@ def harness_source_and_executable(args):
             harness_executable
         })
 
-    # Ensure the files are present in the soruce code
+    # Ensure the files are present in the source code
     with open(all_file_json, 'r') as f:
         all_files_list = json.loads(f.read())
 
@@ -2404,9 +2409,44 @@ def should_ignore_testpath(test_path: str) -> bool:
     return False
 
 
+@api_blueprint.route('/api/ofg-validity-check')
+def ofg_validity_check():
+    """Returns OFG validity check for all projects."""
+
+    results = []
+    for project in data_storage.get_projects():
+        harness_mapping = _get_harness_source_and_executable(project.name)
+
+        mapping_success = True
+        pairs = harness_mapping.get('pairs', [])
+        for pair in pairs:
+            if not isinstance(pair, dict):
+                continue
+            if '/' in pair.get('executable', ''):
+                mapping_success = False
+
+        # Verify fuzz introspector context retrieval
+        fi_context_analysis = _get_fi_context_validity(project.name)
+        results.append({
+            'project': project.name,
+            'mapping_source': mapping_success,
+            'context_status': fi_context_analysis
+        })
+    return {'result': 'success', 'data': results}
+
+
+def _get_fi_context_validity(project_name):
+    """Get context validity for a project."""
+    xref_dict = get_cross_reference_dict_from_project(project_name)
+    total_ref_count = 0
+    for dst, ref_count in xref_dict.items():
+        total_ref_count += ref_count
+    return {'cross-reference-counts': total_ref_count}
+
+
 def extract_project_tests(project_name,
                           refine: bool = True,
-                          try_ignore_irrelevant=True) -> List[str]:
+                          try_ignore_irrelevant=True) -> List[Optional[str]]:
     """Extracts the tests in terms of file paths of a given project"""
     tests_file = os.path.join(
         os.path.dirname(__file__),
@@ -2432,6 +2472,8 @@ def extract_project_tests(project_name,
                                                    target_project,
                                                    project_name)
 
+    if not isinstance(tests_file_list, list):
+        return []
     return tests_file_list
 
 
@@ -2459,7 +2501,10 @@ def _light_project_tests(project_name, try_ignore_irrelevant=True):
     return returner_list
 
 
-def _ignore_irrelevant_tests(tests_file_list, project, project_name):
+def _ignore_irrelevant_tests(tests_file_list,
+                             project,
+                             project_name,
+                             enable_jvm=False):
     """Helper function to ignore irrelevant tests"""
     repo_match = []
 
@@ -2470,7 +2515,9 @@ def _ignore_irrelevant_tests(tests_file_list, project, project_name):
     # Extra filtering for Java project
     # This is to filter irrelevant java test/example sources that does
     # not call any public classes of the project
-    if project and project.language == 'java':
+    # We need to set enable_jvm here because takes a huge amount of
+    # processing time. Must exclude in most cases.
+    if project and project.language == 'java' and enable_jvm:
         result_list = []
 
         # Determine a list of relevant import statements
@@ -2488,7 +2535,7 @@ def _ignore_irrelevant_tests(tests_file_list, project, project_name):
                                          project_name):
                 result_list.append(test_file)
 
-        return result_list
+        return
 
     return repo_match
 
@@ -2570,6 +2617,11 @@ def project_tests(args):
 
     light_tests = _light_project_tests(project)
     test_file_list = extract_project_tests(project)
+    if light_tests is None:
+        light_tests = []
+    if test_file_list is None:
+        test_file_list = []
+
     combined = list(set(test_file_list + light_tests))
     if not combined:
         return {