Skip to content

Commit 560da4c

Browse files
committed
feat: added discrepancies visualization
1 parent 4d63668 commit 560da4c

File tree

2 files changed

+30
-5
lines changed

2 files changed

+30
-5
lines changed

src/components/ProjectComparator.tsx

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import { getRefinedChecks } from "../utils/comparator/getRefinedChecks";
1313
import { areEqualElements } from "../utils/comparator/areEqualElements";
1414

1515
import "../styles/ProjectDetails.css";
16+
import "../styles/ProjectComparator.css";
1617

1718
function ProjectComparator() {
1819
const params = useParams();
@@ -21,6 +22,7 @@ function ProjectComparator() {
2122
const [consolidatedData, setConsolidatedData] = useState<
2223
ConsolidatedScoreElement[]
2324
>([]);
25+
const [discrepancies, setDiscrepancies] = useState<string[]>([]);
2426

2527
const prevCommitQuery = useQuery({
2628
queryKey: ["prevCommit"],
@@ -53,18 +55,16 @@ function ProjectComparator() {
5355

5456
useEffect(() => {
5557
const areEqualDetails = () => {
56-
let consolidatedData;
57-
5858
if (!previousData?.checks || !previousData?.score) {
5959
return;
6060
}
6161

62-
const { common } = getRefinedChecks(
62+
const refinedChecks = getRefinedChecks(
6363
previousData?.checks,
6464
currentData?.checks,
6565
);
6666

67-
consolidatedData = common.map((name: string) => {
67+
const data = refinedChecks.common.map((name: string) => {
6868
const previousElement = previousData?.checks?.filter(
6969
(el: ScoreElement) => el.name === name,
7070
)[0];
@@ -84,7 +84,8 @@ function ProjectComparator() {
8484
prevScore: previousElement.score,
8585
};
8686
});
87-
setConsolidatedData(consolidatedData);
87+
setConsolidatedData(data);
88+
setDiscrepancies(refinedChecks.discrepancies);
8889
};
8990
areEqualDetails();
9091
}, [currentData, previousData]);
@@ -136,6 +137,14 @@ function ProjectComparator() {
136137
{`(${currentData.scorecard.commit.substring(0, 8)})`}
137138
</a>
138139
</p>
140+
{discrepancies.length > 0 && (
141+
<span
142+
className="warning-message"
143+
data-testid="discrepancies"
144+
>{`The report doesn't display certain checks (such as ${discrepancies.join(
145+
", ",
146+
)}) because they haven't been included in the analysis of both commits.`}</span>
147+
)}
139148
<hr />
140149
{Array.isArray(consolidatedData) &&
141150
consolidatedData.map((element: ConsolidatedScoreElement) => (

src/styles/ProjectComparator.css

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
.warning-message {
2+
width: auto;
3+
padding: 10px;
4+
color: white;
5+
background-color: #dc3545;
6+
/*border: 1px solid orange;*/
7+
border-radius: 5px;
8+
font-size: 1rem;
9+
display: inline-block;
10+
font-weight: 600;
11+
}
12+
13+
.warning-message::before {
14+
content: "\1F6A8";
15+
margin-right: 4px;
16+
}

0 commit comments

Comments
 (0)