bump golangci-lint to v1.64.8 (#769)

- bump golangci-lint to last v1 version
  
  We can upgrade to v2 later.

- switch to copyloopvar linter and remove violations

  Since we're above Go 1.22, we can remove all the `tt := tt` occurrences.

---------

Signed-off-by: Spencer Schrock <[email protected]>
Co-authored-by: Stephen Augustus <[email protected]>

Author: spencerschrock

.github/workflows/main.yml

@@ -28,7 +28,7 @@ on:
 env:
   PROTOC_VERSION: 3.17.3
   GO_VERSION: 1.23
-  GOLANGCI_LINT_VERSION: v1.63
+  GOLANGCI_LINT_VERSION: v1.64.8
 
 jobs:
   build-scorecard-webapp:

.golangci.yml

@@ -22,9 +22,9 @@ linters:
   disable-all: true
   enable:
     - asciicheck
+    - copyloopvar
     - dogsled
     - exhaustive
-    - exportloopref
     - gci
     - gochecknoinits
     - goconst

app/server/get_results_test.go

@@ -71,7 +71,6 @@ func TestSanitizePath(t *testing.T) {
 		},
 	}
 	for _, tt := range testcases {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			gotPath, gotErr := sanitizeInputs(tt.host, tt.orgName, tt.repoName, tt.commit)

app/server/internal/hashedrekord/hashedrekord_test.go

@@ -53,7 +53,6 @@ func Test_Body_certs(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			certs, err := tt.body.Certs()
@@ -122,7 +121,6 @@ func Test_Body_Matches(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			b, err := os.ReadFile(tt.blobPath)

app/server/post_results_test.go

@@ -177,7 +177,6 @@ func Test_extractCertInfo(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			got, err := extractCertInfo(tt.args.cert)
@@ -253,7 +252,6 @@ func Test_splitFullPath(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			o, r, p, ok := splitFullPath(tt.path)
@@ -300,7 +298,6 @@ MYSKu39B6Q==
 -----END CERTIFICATE-----`), false, false},
 	}
 	for i, tt := range tests {
-		tt := tt
 		t.Run(fmt.Sprintf("%d", i), func(t *testing.T) {
 			t.Parallel()
 			got, err := getCertPool(tt.cert)
@@ -342,7 +339,6 @@ func Test_getTLogEntryFromURL(t *testing.T) {
 	}
 	ctx := context.Background()
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			url := setupServer(t) + tt.responsePath
@@ -417,7 +413,6 @@ func Test_tlogEntry_rekord(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			r, err := tt.entry.rekord()