Merge pull request #437 from ossf/minor_lab_additions1

david-a-wheeler · web-flow · commit 56d758c7af87 · 2024-03-23T23:42:22.000-04:00
Minor lab additions1
diff --git a/docs/labs/checker.css b/docs/labs/checker.css
@@ -12,3 +12,7 @@ pre input, pre textarea {
 .markdown-body pre textarea, pre textarea {
     resize: both;
 }
+
+.displayNone {
+    display: none;
+}
diff --git a/docs/labs/checker.js b/docs/labs/checker.js
@@ -94,6 +94,8 @@ function showDebugOutput(debugOutput, alwaysAlert = true) {
         // Use textContent to see the raw unfiltered results
         debugDataRegion.textContent = (
             String(debugDataRegion.textContent) + debugOutputString + "\n\n");
+        debugDataRegion.classList.remove('displayNone');
+        // Force display, just in case:
         debugDataRegion.style.display = 'block';
         if (alwaysAlert) alert(debugOutputString);
     } else {
diff --git a/docs/labs/create_checker.md b/docs/labs/create_checker.md
@@ -613,3 +613,18 @@ to refer to the corresponding capturing group.
 
 If you load `hello.html` you'll automatically run some self-tests on
 the default preprocessor.
+
+## Potential future directions
+
+Below are notes about potential future directions.
+
+Currently this system uses simple input and textarea tags
+to retrieve data.
+It might be useful to (optionally?) replace that with a code editor.
+[Wikipedia's Comparison of JavaScript-based source code editors](https://en.wikipedia.org/wiki/Comparison_of_JavaScript-based_source_code_editors) lists many options.
+[CodeJar](https://medv.io/codejar/)
+([CodeJar repo](https://github.com/antonmedv/codejar))
+looks promising. It has an MIT license, only about 2.5kB,
+and you can use a highlighting library such as PrismJS or your own;
+it doesn't do any bracket matching though.
+There are many larger ones such as Ace and CodeMirror.
diff --git a/docs/labs/csp1.html b/docs/labs/csp1.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <html>
 <head>
 <meta http-equiv="X-UA-Compatible" content="IE=edge">
@@ -409,7 +410,7 @@ <h2>Interactive Lab (<span id="grade"></span>)</h2>
 <button type="button" id="giveUpButton">Give up</button>
 <br><br>
 <pre id="correctStamp"></pre>
-<textarea id="debugData" rows="20" cols="70" readonly style="display: none;">
+<textarea id="debugData" class="displayNone" rows="20" cols="70" readonly>
 </textarea>
 </form>
 </div><!-- End GitHub pages formatting -->
diff --git a/docs/labs/hello.html b/docs/labs/hello.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <html>
 <head>
 <meta http-equiv="X-UA-Compatible" content="IE=edge">
@@ -170,7 +171,7 @@ <h2>Interactive Lab (<span id="grade"></span>)</h2>
 <button type="button" id="giveUpButton">Give up</button>
 <br><br>
 <pre id="correctStamp"></pre>
-<textarea id="debugData" rows="20" cols="70" readonly style="display: none;">
+<textarea id="debugData" class="displayNone" rows="20" cols="70" readonly>
 </textarea>
 </form>
 
diff --git a/docs/labs/input1-emulation.html b/docs/labs/input1-emulation.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <html>
 <head>
 <script src="lab_runner.js"></script>
diff --git a/docs/labs/input1.html b/docs/labs/input1.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <html>
 <head>
 <meta http-equiv="X-UA-Compatible" content="IE=edge">
@@ -226,7 +227,7 @@ <h2>Interactive Lab (<span id="grade"></span>)</h2>
 <button type="button" id="giveUpButton">Give up</button>
 <br><br>
 <pre id="correctStamp"></pre>
-<textarea id="debugData" rows="20" cols="70" readonly style="display: none;">
+<textarea id="debugData" class="displayNone" rows="20" cols="70" readonly>
 </textarea>
 </form>
 
diff --git a/docs/labs/input2.html b/docs/labs/input2.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <html>
 <head>
 <meta http-equiv="X-UA-Compatible" content="IE=edge">
@@ -217,7 +218,7 @@ <h2>Interactive Lab (<span id="grade"></span>)</h2>
 <button type="button" id="giveUpButton">Give up</button>
 <br><br>
 <pre id="correctStamp"></pre>
-<textarea id="debugData" rows="20" cols="70" readonly style="display: none;">
+<textarea id="debugData" class="displayNone" rows="20" cols="70" readonly>
 </textarea>
 </form>
 

Original file line number	Diff line number	Diff line change
`@@ -12,3 +12,7 @@ pre input, pre textarea {`
`12`	`12`	`.markdown-body pre textarea, pre textarea {`
`13`	`13`	`resize: both;`
`14`	`14`	`}`
	`15`	`+`
	`16`	`+.displayNone {`
	`17`	`+ display: none;`
	`18`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+<!DOCTYPE html>`
`1`	`2`	`<html>`
`2`	`3`	`<head>`
`3`	`4`	`<script src="lab_runner.js"></script>`