Skip to content

Commit 928df16

Browse files
committed
Merge branches 'main' and 'main' of github.com:myteron/wg-best-practices-os-developers
2 parents 70f0565 + ac7f7d0 commit 928df16

File tree

4 files changed

+66
-5
lines changed

4 files changed

+66
-5
lines changed

README.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,16 @@ Formal specifications would be licensed under the
241241
[Community Specification License](https://github.com/CommunitySpecification/1.0)
242242
(though at this time we don't have any examples of that).
243243

244+
## Reviewing translations
245+
246+
We are _delighted_ that some are willing to help us translate materials
247+
to other languages. Please ensure all
248+
pull requests that add or modify translations are labeled with its language.
249+
Such pull requests (PRs) must be first
250+
reviewed and approved by a trusted translator.
251+
252+
See [translations](docs/translations) for specific details.
253+
244254
## Charter
245255

246256
Like all OpenSSF working groups, this working group reports to the

docs/Secure-Coding-Guide-for-Python/readme.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Secure Coding One Stop Shop for Python
22

3+
> ⓘ NOTE: This is a draft. Contributions welcome!
4+
35
An initiative by the OpenSSF to provide new Python programmers a resource to study secure coding in `CPython >= 3.9` with working code examples.
46

57
Documentation is written in academic style to support security researchers while using plain English to cater for an international audience.
@@ -23,12 +25,12 @@ Every person writing code shall study the following:
2325

2426
## Secure Coding Standard for Python
2527

26-
Code examples are written to explain security design with as little code as possible. __None__ of the code examples are intendet to be used 'as is' for production. Using the code is at your own risk!
28+
Code examples are written to explain security design with as little code as possible. __None__ of the code examples are intended to be used 'as is' for production. Using the code is at your own risk!
2729

28-
__Code file naminng conventions:__
30+
__Code file naming conventions:__
2931

30-
* `noncompliantXX.py` anti-pattern.
31-
* `compliantXX.py` mitigation for mitigating or removal of __ONLY__ the described risk.
32+
* `noncompliantXX.py` anti-pattern, bad programming practice.
33+
* `compliantXX.py` mitigation or removal of __ONLY__ the described risk.
3234
* `exampleXX.py` to allow understanding the documented behaviour.
3335

3436
It is __not production code__ and requires code-style or python best practices to be added such as:

docs/index.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,17 @@ Note: You can also see the larger list of
2424
* [Security Scorecard](https://github.com/ossf/scorecard) - automated scoring of OSS projects
2525
* [OpenSSF Best Practices badge](https://www.bestpractices.dev/) - a way for Free/Libre/Open Source Software projects to show that they follow best practices (you can also see its [source code repository](https://github.com/coreinfrastructure/best-practices-badge)).
2626

27-
## Future work
27+
## Ongoing work
2828

2929
The OpenSSF Best Practices WG is working on many more materials, such as
3030
more educational materials through our education special interest group (SIG),
3131
compiler hardening guides,
3232
guidance about memory safety through our memory safety SIG, and so on.
3333

34+
Examples of ongoing work include:
35+
36+
* [Secure Coding One Stop Shop for Python](Secure-Coding-Guide-for-Python/readme.md)
37+
3438
[Please join the OpenSSF Best Practices working group if you're interested in helping](https://github.com/ossf/wg-best-practices-os-developers)!
3539

3640
Please also see the

docs/translations.md

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
# Translations
2+
3+
We are *delighted* that people are willing to work to translate materials
4+
into various languages such as Japanese. Here is how we review translation PRs
5+
in this repo to ensure translations are good ones.
6+
7+
## Translation review process
8+
9+
To ensure that translations are good ones:
10+
11+
1. All pull requests (PRs) that add or modify a translation
12+
*must* be labeled as such.
13+
The label is the language name, e.g., "Japanese" for Japanese.
14+
Anyone can add that label, including the originator,
15+
if the repository permissions allow it.
16+
This way, missing labels can be easily added.
17+
2. A member of the "trusted translation team" for that language
18+
will review those PRs for translation accuracy. At least one
19+
such member MUST approve the PR before it can be merged.
20+
If the PR comes *from* one if its team members, it's presumed to be
21+
approved by that team.
22+
If the label is wrong, a trusted translation team member
23+
should remove the label.
24+
3. Someone else will also review the PR for any other issues,
25+
using the usual review processes, and indicate it's approved
26+
if it's approved.
27+
28+
Whenever both a trusted translation team member approves (2) AND it's
29+
been approved otherwise (3), in any order, the PR can be merged.
30+
31+
## Trusted translation team members
32+
33+
Here are the trusted translation team members for each language,
34+
including their name and GitHub id.
35+
Any member of a trusted translation team can add other members to their team.
36+
37+
The OpenSSF TAC or Best Practices WG can create and remove teams,
38+
and can add or remove members in such teams. In practice we expect anything
39+
other than creating a team to be rare events for them.
40+
41+
### Japanese
42+
43+
* Non KAWANA - ninan27
44+
* Muuhh IKEDA - Muuhh-CTJ
45+
* Taku SHIMOSAWA - shimos

0 commit comments

Comments
 (0)