Merge pull request #767 from ossf/improve_oob1

Improve lab oob1

Author: david-a-wheeler

docs/labs/oob1.html

@@ -83,16 +83,16 @@ <h2>Task Information</h2>
 if the minimum length of a response <tt>(1 + 2 + 16)</tt> is more than
 the length claimed by
 <tt>s->s3->rrec.length</tt>,
-and return 0 without sending a heartbeat,
+then return 0 without sending a heartbeat,
 This will prevent trying to create a heartbeat when there's not enough
 room to create a heartbeat at all.
 <p>
 Second, modify the code so that
 if the minimum length of a response with a payload
-<tt>(1 + 2 + payload + 16</tt>
+<tt>(1 + 2 + payload + 16)</tt>
 is more than the total length for a response given in
 <tt>s->s3->rrec.length</tt> then again
-return 0 without sending a heartbeat,
+return 0 without sending a heartbeat.
 <p>
 This will prevent trying to create a heartbeat when there's not enough
 room to create one and there was a payload to return as a heartbeat.

docs/labs/oob1.js

@@ -2,24 +2,66 @@ info =
 {
   hints: [
     {
-      absent: "if",
-      text: "Begin with \"if\" as we will return 0 when there is a problem."
+      absent: "^ if",
+      text: "Begin with \"if\" as we will return 0 when there is a problem.",
+      examples: [
+        [ " foo " ],
+      ],
     },
     {
-      absent: String.raw`\(`,
-      text: "Need \"(...)\" around the condition after an if statement."
+      absent: String.raw`\(.*\)`,
+      text: "Need \"(...)\" around the condition after an if statement.",
+      examples: [
+        [ " if " ],
+      ],
     },
     {
-      absent: ">",
-      text: "Need comparison \"if ( ... > ....)\""
+      absent: "[<>]",
+      text: "Need comparison \"if ( ... > ....)\"",
+      examples: [
+        [ " if ( x )" ],
+      ],
     },
     {
       absent: String.raw`s -> s3 -> rrec \. length`,
-      text: "Need to compare a value with s->s3->rrec.length"
+      text: "Need to compare a value with s->s3->rrec.length",
+      examples: [
+        [ " if ( length > 3 )" ],
+      ],
     },
     {
-      absent: "return",
-      text: "Need \"return 0;\" to skip attempts to send a too-long response."
+      absent: "return 0 ;",
+      text: "Need \"return 0;\" to skip attempts to send a too-long response.",
+    },
+    {
+      absent: "^ if",
+      text: "Begin with \"if\" as we will return 0 when there is a problem.",
+      index: 1,
+    },
+    {
+      absent: String.raw`\(.*\)`,
+      text: "Need \"(...)\" around the condition after an if statement.",
+      index: 1,
+    },
+    {
+      absent: "[<>]",
+      text: "Need comparison \"if ( ... > ....)\"",
+      index: 1,
+    },
+    {
+      absent: String.raw`s -> s3 -> rrec \. length`,
+      text: "Need to compare a value with s->s3->rrec.length",
+      index: 1,
+    },
+    {
+      absent: "return 0 ;",
+      text: "Need \"return 0;\" to skip attempts to send a too-long response.",
+      index: 1,
+    },
+    {
+      absent: "payload",
+      text: "Need to consider the payload length.",
+      index: 1,
     },
   ],
   definitions: [