pySCG bugfix for CWE-191 as per #835 #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Helge Wehder <[email protected]>
|
I am reviewing this. |
| try: | ||
| result = get_datetime(currtime, hours) | ||
| print(f"{hours} OK, datetime='{result}'") | ||
| except Exception as exception: |
There was a problem hiding this comment.
I am getting this error in Pylint, saying that the exception is too general:
Catching too general exception ExceptionPylintW0718:broad-exception-caught
There was a problem hiding this comment.
attack section is not expected to be clean
| try: | ||
| result = get_datetime(currtime, hours) | ||
| print(f"{hours} OK, datetime='{result}'") | ||
| except Exception as exception: |
There was a problem hiding this comment.
Again with the general exception warning, not sure if it is relevant a I believe you want to catch all exceptions:
Catching too general exception ExceptionPylintW0718:broad-exception-caught
There was a problem hiding this comment.
the attack section does not require to be 'compliant' so won't change this.
Co-authored-by: andrew-costello <[email protected]> Signed-off-by: myteron <[email protected]>
BartKaras1128
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to address issues reported in #835 , the excessive attack section might be to much but covers all boundaries I discovered.