SRS(docker,6.0.184) stops to accept on RTMP port.

[tubzby]

Describe the bug
We are using SRS to provide rtmp/flv access to our video streams, after running for 4 hours, it then stopped to accept new socket, tcpdump show only TCP-SYNC sent without receiving ACKs.

gdb attach to srs process shows the process was in epoll, which is reasonable.

I have checked ulimit, and it's ok with my setup.

Since my log contains some internal IDs, I'm not uploading it here.

Version
Docker image: 6.0.148

To Reproduce
No idea

Expected behavior

RTMP port work as normal.

Screenshots
N/A.

Additional context
N/A

[tubzby]

Seems that I have set an incorrect max_connections in the config file.

I think we should print some error logs if we hit a limit.

[suzp1984]

This issue only exist in 6.0 release, 7.0 or develop branch already fixed it.

srs/trunk/src/app/srs_app_listener.cpp

Lines 335 to 338 in 93c5d72

	if ((err = do_cycle()) != srs_success) {
	srs_warn("%s listener: Ignore error, %s", label_.c_str(), srs_error_desc(err).c_str());
	srs_freep(err);
	}

Here is the 6.0 release corresponding code:

srs/trunk/src/app/srs_app_listener.cpp

Lines 316 to 318 in 1316ceb

	if ((err = handler->on_tcp_client(this, fd)) != srs_success) {
	return srs_error_wrap(err, "handle fd=%d", srs_netfd_fileno(fd));
	}

Cause

The 6.0 release: the Tcp (maybe also UDP) Listener's will skip the cycle loop when error happens, while the develop branch will
ignore the errors and continue the cycle loop to accept next connection. The errors here include the max connections limitation.

Bugs

Once the tcp listener met an error, it'll never accept the new incoming connections anymore, the max connection limit is one of the examples.

I think the more serious problem of this issue is that srs will not accept any tcp connections after the max connections errors.

The develop branch already gives the solution, I'll try to add srs logs, ignore the errors and let the srs accept further tcp | udp connections in this cases.

[suzp1984]

#4615 fixed this issue, and already merged to 6.0release branch. So close this issue.