Skip to content

Commit df539f3

Browse files
reid-spencerclaude
andcommitted
Save session: prettify fixes, release 1.12.1
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 1eaf74f commit df539f3

File tree

2 files changed

+43
-18
lines changed

2 files changed

+43
-18
lines changed

CLAUDE.md

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -829,9 +829,8 @@ Then add to root aggregation: `.aggregate(..., mymodule, mymoduleJS, mymoduleNat
829829
ARM64. Removing `inline` fixes it; the compiler optimizes
830830
trivial delegations anyway. Filed as
831831
https://github.com/scala/scala3/issues/25306
832-
66. **Current release is 1.12.0** — Minor release with
833-
prettify multi-file structure preservation fix. Supersedes
834-
1.11.1
832+
66. **Current release is 1.12.1** — Patch release fixing
833+
prettify formatting regressions. Supersedes 1.12.0
835834
67. **PrettifyPass multi-file mode**`PrettifyPass.Options`
836835
now carries `topFile`, `outputDir`, and `flatten`. When
837836
`flatten=false` (the new default), prettify preserves
@@ -853,3 +852,18 @@ Then add to root aggregation: `.aggregate(..., mymodule, mymoduleJS, mymoduleNat
853852
(hugo-theme-learn, redislabs-docs, hugo-theme-docdock)
854853
were causing warnings on `git pull`. No submodule paths
855854
were tracked in the tree; only `.gitmodules` remained
855+
71. **Current release is 1.12.1** — Patch release fixing three
856+
prettify formatting regressions from 1.12.0: removed
857+
commas between aggregate fields, kept `} with {` on same
858+
line for types with metadata, preserved relative include
859+
paths. Supersedes 1.12.0
860+
72. **RiddlFileEmitter.trimTrailingNewline()** — Removes a
861+
trailing newline from the StringBuilder. Used in
862+
`closeType` to join `}` from `emitFields` with ` with {`
863+
from `emitMetaData` on the same line. May be needed in
864+
other close methods if similar patterns arise
865+
73. **Include paths use url.path**`openInclude` in
866+
`PrettifyVisitor` uses `url.path` (relative filename)
867+
instead of `url.toExternalForm` (absolute `file:///`
868+
URL). This preserves the original include path as written
869+
in the source model

NOTEBOOK.md

Lines changed: 26 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,39 @@ This is the central engineering notebook for the RIDDL project. It tracks curren
66

77
## Current Status
88

9-
**Last Updated**: February 18, 2026
9+
**Last Updated**: February 19, 2026
10+
11+
### Release 1.12.1 Published (Feb 19, 2026)
12+
13+
Patch release fixing three prettify formatting regressions
14+
found after 1.12.0 when testing against riddl-models:
15+
16+
1. **Commas between aggregate fields**`emitFields()` was
17+
inserting commas between fields. RIDDL grammar makes commas
18+
optional and original models don't use them. Removed all
19+
comma insertion logic.
20+
21+
2. **`} with {` on separate lines for types** — When a type
22+
had metadata, `emitFields` ended with `}\n` and then
23+
`closeType` called `emitMetaData` starting with ` with {`,
24+
putting them on separate lines. Added
25+
`trimTrailingNewline()` to `RiddlFileEmitter` and call it
26+
in `closeType` before `emitMetaData`.
27+
28+
3. **Absolute include paths**`openInclude` used
29+
`url.toExternalForm` producing `file:///Users/...` URLs.
30+
Changed to `url.path` which preserves the relative path.
31+
32+
Three regression tests added. All 277 passes tests pass.
33+
Published to GitHub Packages (JVM, JS, Native). Release
34+
artifacts triggered via CI.
1035

1136
### Release 1.12.0 Published (Feb 18, 2026)
1237

1338
Minor release fixing prettify to retain multi-file include/
1439
import structure. Previously `riddlc prettify` always produced
1540
a single flattened file regardless of `--single-file` flag.
1641

17-
Key changes:
18-
- `singleFile` default changed from `true` to `false`
19-
- `PrettifyPass.Options` expanded with `topFile`/`outputDir`
20-
- `PrettifyState` URL normalization for absolute output paths
21-
- BASTImport added to HierarchyPass/PassVisitor/VisitingPass
22-
- Include quote bug fixed in PrettifyVisitor
23-
- `writeOutput` uses output dir consistently, `TRUNCATE_EXISTING`
24-
- Two regression tests added (multi-file + flatten modes)
25-
- Stale Hugo submodule references removed (`.gitmodules`)
26-
27-
All tests pass. Published to GitHub Packages (JVM, JS, Native).
28-
Release artifacts (native binaries, npm) generated via CI.
29-
Docker image build was cancelled (timed out).
30-
3142
### Release 1.11.1 Published (Feb 17, 2026)
3243

3344
Patch release with PrettifyPass formatting fixes and CI test

0 commit comments

Comments
 (0)