Use O(1) dict lookups for player collection get/contains (#747)

Replace linear O(n) scans with dict-based O(1) lookups for
Players.get(), Players.__contains__(), append(), and remove().

Three private dicts (_by_token, _by_id, _by_name) are maintained
alongside the list to enable constant-time lookups by token, id,
or safe_name. Also fixes an existing bug in __contains__ where the
parameter `player` shadowed the outer variable in the generator.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: cmyui

app/objects/collections.py

@@ -124,15 +124,16 @@ class Players(list[Player]):
 
     def __init__(self, *args: Any, **kwargs: Any) -> None:
         super().__init__(*args, **kwargs)
+        self._by_token: dict[str, Player] = {}
+        self._by_id: dict[int, Player] = {}
+        self._by_name: dict[str, Player] = {}
 
     def __iter__(self) -> Iterator[Player]:
         return super().__iter__()
 
     def __contains__(self, player: object) -> bool:
-        # allow us to either pass in the player
-        # obj, or the player name as a string.
         if isinstance(player, str):
-            return player in (player.name for player in self)
+            return make_safe_name(player) in self._by_name
         else:
             return super().__contains__(player)
 
@@ -172,17 +173,12 @@ def get(
         name: str | None = None,
     ) -> Player | None:
         """Get a player by token, id, or name from cache."""
-        for player in self:
-            if token is not None:
-                if player.token == token:
-                    return player
-            elif id is not None:
-                if player.id == id:
-                    return player
-            elif name is not None:
-                if player.safe_name == make_safe_name(name):
-                    return player
-
+        if token is not None:
+            return self._by_token.get(token)
+        elif id is not None:
+            return self._by_id.get(id)
+        elif name is not None:
+            return self._by_name.get(make_safe_name(name))
         return None
 
     async def get_sql(
@@ -266,22 +262,28 @@ async def from_login(
         return None
 
     def append(self, player: Player) -> None:
-        """Append `p` to the list."""
+        """Append `player` to the list."""
         if player in self:
             if app.settings.DEBUG:
                 log(f"{player} double-added to global player list?")
             return
 
         super().append(player)
+        self._by_token[player.token] = player
+        self._by_id[player.id] = player
+        self._by_name[player.safe_name] = player
 
     def remove(self, player: Player) -> None:
-        """Remove `p` from the list."""
+        """Remove `player` from the list."""
         if player not in self:
             if app.settings.DEBUG:
                 log(f"{player} removed from player list when not online?")
             return
 
         super().remove(player)
+        del self._by_token[player.token]
+        del self._by_id[player.id]
+        del self._by_name[player.safe_name]
 
 
 async def initialize_ram_caches() -> None: