Improve handling of tsx (#37)

* Improve handling of tsx

* update

Author: ota-meshi

src/context/resolve-parser/espree.ts

@@ -1,24 +1,7 @@
-import Module from "module"
+import { createRequire } from "module"
 import path from "path"
 import type { ESLintCustomParser } from "../../types"
 
-const createRequire: (filename: string) => (modName: string) => any =
-    // Added in v12.2.0
-    Module.createRequire ||
-    // Added in v10.12.0, but deprecated in v12.2.0.
-    // @ts-expect-error -- old type
-    Module.createRequireFromPath ||
-    // Polyfill - This is not executed on the tests on node@>=10.
-    /* istanbul ignore next */
-    ((modName) => {
-        const mod = new Module(modName)
-
-        mod.filename = modName
-        mod.paths = (Module as any)._nodeModulePaths(path.dirname(modName))
-        ;(mod as any)._compile("module.exports = require;", modName)
-        return mod.exports
-    })
-
 let espreeCache: ESLintCustomParser | null = null
 
 /** Checks if given path is linter path */

src/parser/script.ts

@@ -1,9 +1,9 @@
 import type { Context } from "../context"
-import fs from "fs"
 import { debug } from "../debug"
 import type { ParserOptionsContext } from "../context/parser-options"
 import type { ESLintExtendedProgram } from "../types"
-
+import { tsPatch } from "./ts-patch"
+import type { ParserOptions } from "@typescript-eslint/types"
 /**
  * Parse for script
  */
@@ -14,23 +14,22 @@ export function parseScript(
 ): ESLintExtendedProgram {
     const parser = parserOptions.getParser()
 
-    let removeFile: string | null = null
+    let patchResult
 
     try {
-        const scriptParserOptions = { ...parserOptions.parserOptions }
+        const scriptParserOptions: ParserOptions = {
+            ...parserOptions.parserOptions,
+        }
+        scriptParserOptions.ecmaFeatures = {
+            ...(scriptParserOptions.ecmaFeatures || {}),
+            jsx: true,
+        }
         if (
             parserOptions.isTypeScript() &&
             scriptParserOptions.filePath &&
             scriptParserOptions.project
         ) {
-            scriptParserOptions.filePath += ".tsx"
-            if (!fs.existsSync(scriptParserOptions.filePath)) {
-                fs.writeFileSync(
-                    scriptParserOptions.filePath,
-                    "/* temp for astro-eslint-parser */",
-                )
-                removeFile = scriptParserOptions.filePath
-            }
+            patchResult = tsPatch(scriptParserOptions)
         }
         const result =
             parser.parseForESLint?.(code, scriptParserOptions) ??
@@ -50,6 +49,6 @@ ${code}`,
         )
         throw e
     } finally {
-        if (removeFile) fs.unlinkSync(removeFile)
+        patchResult?.terminate()
     }
 }

src/parser/ts-patch.ts

@@ -0,0 +1,71 @@
+import { createRequire } from "module"
+import type { ParserOptions } from "@typescript-eslint/types"
+import path from "path"
+import fs from "fs"
+import type { ScriptKind } from "typescript"
+type TS = {
+    ScriptKind: typeof ScriptKind
+    ensureScriptKind?: (fileName: string, ...args: any[]) => ScriptKind
+    getScriptKindFromFileName?: (fileName: string, ...args: any[]) => ScriptKind
+}
+
+export type PatchTerminate = { terminate: () => void }
+
+/**
+ * Apply a patch to parse .astro files as TSX.
+ */
+export function tsPatch(
+    scriptParserOptions: ParserOptions,
+): PatchTerminate | null {
+    try {
+        // Apply a patch to parse .astro files as TSX.
+        const cwd = process.cwd()
+        const relativeTo = path.join(cwd, "__placeholder__.js")
+        const ts: TS = createRequire(relativeTo)("typescript")
+
+        const { ensureScriptKind, getScriptKindFromFileName } = ts
+        if (
+            typeof ensureScriptKind === "function" &&
+            typeof getScriptKindFromFileName === "function"
+        ) {
+            ts.ensureScriptKind = function (fileName: string, ...args: any[]) {
+                if (fileName.endsWith(".astro")) {
+                    return ts.ScriptKind.TSX
+                }
+                return ensureScriptKind.call(this, fileName, ...args)
+            }
+            ts.getScriptKindFromFileName = function (
+                fileName: string,
+                ...args: any[]
+            ) {
+                if (fileName.endsWith(".astro")) {
+                    return ts.ScriptKind.TSX
+                }
+                return getScriptKindFromFileName.call(this, fileName, ...args)
+            }
+            return {
+                terminate() {
+                    ts.ensureScriptKind = ensureScriptKind
+                    ts.getScriptKindFromFileName = getScriptKindFromFileName
+                },
+            }
+        }
+    } catch {
+        // ignore
+    }
+
+    // If the patch cannot be applied, create a tsx file and parse it.
+    const tsxFilePath = `${scriptParserOptions.filePath}.tsx`
+    scriptParserOptions.filePath = tsxFilePath
+    if (!fs.existsSync(tsxFilePath)) {
+        fs.writeFileSync(tsxFilePath, "/* temp for astro-eslint-parser */")
+
+        return {
+            terminate() {
+                fs.unlinkSync(tsxFilePath)
+            },
+        }
+    }
+
+    return null
+}

tests/fixtures/parser/tsconfig.test.json

@@ -1,5 +1,5 @@
 {
     "include": [
-        "**/*.astro.tsx"
+        "**/*.astro"
     ]
 }