Skip to content

Commit 6dd88e4

Browse files
authored
Fix jsonc/auto detection of rules being "off" (#188)
Co-authored-by: Clement Yan <[email protected]>
1 parent 7de41de commit 6dd88e4

File tree

3 files changed

+18
-2
lines changed

3 files changed

+18
-2
lines changed

lib/utils/get-auto-jsonc-rules-config.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,11 @@ export function getAutoConfig(filename: string): {
134134
const jsoncName = getJsoncRule(ruleName)
135135
if (jsoncName && !config.rules[jsoncName]) {
136136
const entry = config.rules[ruleName]
137-
if (entry && entry !== "off") {
138-
autoConfig[jsoncName] = entry
137+
if (entry) {
138+
const severity = Array.isArray(entry) ? entry[0] : entry
139+
if (severity !== "off" && severity !== 0) {
140+
autoConfig[jsoncName] = entry
141+
}
139142
}
140143
}
141144
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"root": true,
3+
"extends": ["eslint:all"],
4+
"rules": {
5+
"indent": ["off", 4]
6+
}
7+
}

tests/lib/rules/auto.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,12 @@ tester.run("auto", rule as any, {
2424
</i18n>`,
2525
parser: require.resolve("vue-eslint-parser"),
2626
},
27+
{
28+
filename: path.join(ROOT_DIR, "test03", "test.json"),
29+
code: `{
30+
"foo": "bar"
31+
}`,
32+
},
2733
],
2834
invalid: [
2935
{

0 commit comments

Comments
 (0)