Fixed bug that rules not work when using jsonc-eslint-parser as vue-eslint-parser fallback parser (#32)

* Fixed bug that rules not work when using jsonc-eslint-parser as vue-eslint-parser fallback parser

* fix

* fix

Author: ota-meshi

lib/utils/index.ts

@@ -3,6 +3,7 @@ import type { Rule } from "eslint"
 import type { AST } from "jsonc-eslint-parser"
 import * as jsoncESLintParser from "jsonc-eslint-parser"
 import type { AST as V } from "vue-eslint-parser"
+import path from "path"
 
 /**
  * Define the rule.
@@ -27,7 +28,8 @@ export function createRule(
         create(context: Rule.RuleContext): any {
             if (
                 typeof context.parserServices.defineCustomBlocksVisitor ===
-                "function"
+                    "function" &&
+                path.extname(context.getFilename()) === ".vue"
             ) {
                 return context.parserServices.defineCustomBlocksVisitor(
                     context,

tests-integrations/fixtures/vue-eslint-parser-option/.eslintrc.json

@@ -0,0 +1,15 @@
+{
+    "root": true,
+    "plugins": [
+        "jsonc"
+    ],
+    "parser": "vue-eslint-parser",
+    "parserOptions": {
+        "parser": "jsonc-eslint-parser",
+        "sourceType": "module",
+        "ecmaVersion": 2015
+    },
+    "rules": {
+        "jsonc/indent": "error"
+    }
+}

tests-integrations/fixtures/vue-eslint-parser-option/.npmrc

@@ -0,0 +1 @@
+package-lock=false

tests-integrations/fixtures/vue-eslint-parser-option/package.json

@@ -0,0 +1,17 @@
+{
+  "name": "test-for-eslint-plugin-jsonc-with-vue",
+  "private": true,
+  "version": "1.0.0",
+  "description": "",
+  "main": "index.js",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "author": "",
+  "license": "MIT",
+  "devDependencies": {
+    "eslint": "^7.17.0",
+    "vue-eslint-parser": "^7.3.0",
+    "eslint-plugin-jsonc": "file:../../../"
+  }
+}

tests-integrations/fixtures/vue-eslint-parser-option/test.json

@@ -0,0 +1,3 @@
+{
+"a": "b"
+}

tests-integrations/lib/eslint-plugin-markdown.ts

@@ -23,7 +23,7 @@ describe("Integration with eslint-plugin-markdown", () => {
         process.chdir(originalCwd)
     })
 
-    it("should lint without errors", () => {
+    it("should lint errors", () => {
         /* eslint-disable @typescript-eslint/ban-ts-comment, @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports -- test */
         // @ts-ignore
         const eslint = require(ESLINT)

tests-integrations/lib/vue-eslint-parser-option.ts

@@ -0,0 +1,45 @@
+import cp from "child_process"
+import assert from "assert"
+import path from "path"
+import plugin from "../../lib/index"
+
+// -----------------------------------------------------------------------------
+// Tests
+// -----------------------------------------------------------------------------
+
+const TEST_CWD = path.join(__dirname, "../fixtures/vue-eslint-parser-option")
+
+const ESLINT = path.join(TEST_CWD, `./node_modules/eslint`)
+
+describe("Integration with vue-eslint-parser with option", () => {
+    let originalCwd: string
+
+    before(() => {
+        originalCwd = process.cwd()
+        process.chdir(TEST_CWD)
+        cp.execSync("npm i", { stdio: "inherit" })
+    })
+    after(() => {
+        process.chdir(originalCwd)
+    })
+
+    it("should lint errors", () => {
+        /* eslint-disable @typescript-eslint/ban-ts-comment, @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports -- test */
+        // @ts-ignore
+        const eslint = require(ESLINT)
+        /* eslint-enable @typescript-eslint/ban-ts-comment, @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports -- test */
+        const engine = new eslint.CLIEngine({
+            cwd: TEST_CWD,
+            extensions: [".js", ".json", ".yaml"],
+        })
+        engine.addPlugin("eslint-plugin-jsonc", plugin)
+        const r = engine.executeOnFiles(["./test.json"])
+
+        assert.strictEqual(r.results.length, 1)
+        assert.strictEqual(r.results[0].messages.length, 1)
+        assert.strictEqual(
+            r.results[0].messages[0].message,
+            "Expected indentation of 4 spaces but found 0.",
+        )
+    })
+})

tests/lib/rules/array-bracket-newline.ts

@@ -25,6 +25,7 @@ tester.run("array-bracket-newline", rule as any, {
             ],
         },
         {
+            filename: "test.vue",
             code: `<i18n>[1,\n2]</i18n><custom-block lang="json">[\n1\n]</custom-block>`,
             output: `<i18n>[\n1,\n2\n]</i18n><custom-block lang="json">[1]</custom-block>`,
             parser: require.resolve("vue-eslint-parser"),

tests/lib/rules/array-bracket-spacing.ts

@@ -17,6 +17,7 @@ tester.run("array-bracket-spacing", rule as any, {
             ],
         },
         {
+            filename: "test.vue",
             code: `<i18n>[ 1, 2 ]</i18n><custom-block lang="jsonc">[ 1 ]</custom-block>`,
             output: `<i18n>[1, 2]</i18n><custom-block lang="jsonc">[1]</custom-block>`,
             parser: require.resolve("vue-eslint-parser"),

tests/lib/rules/array-element-newline.ts

@@ -23,6 +23,7 @@ tester.run("array-element-newline", rule as any, {
             ],
         },
         {
+            filename: "test.vue",
             code: `<i18n>[1, 2, 3]</i18n><custom-block lang="json5">[1, 2, 3]</custom-block>`,
             output: `<i18n>[1,
 2,