Improve regexp/no-invalid-regexp rule to check for unknown pattern flags. (#583)

Author: ota-meshi

.changeset/warm-ladybugs-wonder.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-regexp": minor
+---
+
+Improve `regexp/no-invalid-regexp` rule to check for unknown pattern flags.

lib/rules/no-invalid-regexp.ts

@@ -1,4 +1,4 @@
-import type { RegExpContextForInvalid } from "../utils"
+import type { RegExpContextForInvalid, RegExpContextForUnknown } from "../utils"
 import { createRule, defineRegexpVisitor } from "../utils"
 
 /** Returns the position of the error */
@@ -22,6 +22,8 @@ export default createRule("no-invalid-regexp", {
         schema: [],
         messages: {
             error: "{{message}}",
+            duplicateFlag: "Duplicate {{flag}} flag.",
+            uvFlag: "Regex 'u' and 'v' flags cannot be used together.",
         },
         type: "problem",
     },
@@ -56,6 +58,33 @@ export default createRule("no-invalid-regexp", {
             })
         }
 
-        return defineRegexpVisitor(context, { visitInvalid })
+        /** Checks for the combination of `u` and `v` flags */
+        function visitUnknown(regexpContext: RegExpContextForUnknown): void {
+            const { node, flags, flagsString, getFlagsLocation } = regexpContext
+
+            const flagSet = new Set<string>()
+            for (const flag of flagsString ?? "") {
+                if (flagSet.has(flag)) {
+                    context.report({
+                        node,
+                        loc: getFlagsLocation(),
+                        messageId: "duplicateFlag",
+                        data: { flag },
+                    })
+                    return
+                }
+                flagSet.add(flag)
+            }
+
+            if (flags.unicode && flags.unicodeSets) {
+                context.report({
+                    node,
+                    loc: getFlagsLocation(),
+                    messageId: "uvFlag",
+                })
+            }
+        }
+
+        return defineRegexpVisitor(context, { visitInvalid, visitUnknown })
     },
 })

tests/lib/rules/no-invalid-regexp.ts

@@ -44,5 +44,24 @@ tester.run("no-invalid-regexp", rule as any, {
                 },
             ],
         },
+
+        {
+            code: "new RegExp(pattern, 'uu');",
+            errors: [
+                {
+                    message: "Duplicate u flag.",
+                    column: 22,
+                },
+            ],
+        },
+        {
+            code: "new RegExp(pattern, 'uv');",
+            errors: [
+                {
+                    message: "Regex 'u' and 'v' flags cannot be used together.",
+                    column: 22,
+                },
+            ],
+        },
     ],
 })