Skip to content

Commit 230a319

Browse files
authored
Fix false positives for quantifier in regexp/no-useless-non-capturing-group rule (#66)
1 parent bc5aae0 commit 230a319

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

lib/rules/no-useless-non-capturing-group.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ export default createRule("no-useless-non-capturing-group", {
4747
const parent = gNode.parent
4848
if (
4949
parent.type === "Quantifier" &&
50-
alt.elements.length > 1
50+
(alt.elements.length > 1 ||
51+
alt.elements[0].type === "Quantifier")
5152
) {
5253
// e.g. /(?:ab)?/
5354
return

tests/lib/rules/no-useless-non-capturing-group.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ tester.run("no-useless-non-capturing-group", rule as any, {
1717
String.raw`/()\1(?:0)/`,
1818
String.raw`/\1(?:0)/`,
1919
String.raw`/\0(?:1)/`,
20+
String.raw`/(\d)(?=(?:\d{3})+(?!\d))/g`,
2021
],
2122
invalid: [
2223
{

0 commit comments

Comments
 (0)