Change default configuration of prefer-d (#715)

* Change default configuration of `prefer-d`

* Create shaggy-lemons-suffer.md

Author: RunDevelopment

.changeset/shaggy-lemons-suffer.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-regexp": minor
+---
+
+Change default configuration of `prefer-d` to ignore digits inside character classes.

docs/rules/prefer-d.md

@@ -55,7 +55,7 @@ This option control how character class element equivalent to `\d` will be treat
 *Note:* This option does not affect character classes equivalent to `\d`. E.g. `[\d]`, `[0-9]`, and `[0123456789]` are unaffected.
 It also does not affect expression non-nested operands equivalent to `\d`. E.g. `[\d&&x]`, and `[\d--x]` are unaffected.
 
-- `insideCharacterClass: "d"` (*default*)
+- `insideCharacterClass: "d"`
 
   Character class element equivalent to `\d` will be reported and replaced with `\d`.
 
@@ -98,7 +98,7 @@ It also does not affect expression non-nested operands equivalent to `\d`. E.g.
 
   </eslint-code-block>
 
-- `insideCharacterClass: "ignore"`
+- `insideCharacterClass: "ignore"` (*default*)
 
   Character class element will not be reported.
 

lib/rules/prefer-d.ts

@@ -60,7 +60,7 @@ export default createRule("prefer-d", {
     },
     create(context) {
         const insideCharacterClass: "ignore" | "range" | "d" =
-            context.options[0]?.insideCharacterClass ?? "d"
+            context.options[0]?.insideCharacterClass ?? "ignore"
 
         function createVisitor({
             node,

tests/lib/eslint-plugin.ts

@@ -45,7 +45,6 @@ describe("Integration with eslint-plugin-regexp", async () => {
                     "regexp/no-dupe-characters-character-class",
                     "regexp/prefer-w",
                     "regexp/prefer-d",
-                    "regexp/prefer-d",
                     "regexp/use-ignore-case",
                 ],
             )
@@ -75,7 +74,6 @@ describe("Integration with eslint-plugin-regexp", async () => {
                 "regexp/no-dupe-characters-character-class",
                 "regexp/prefer-w",
                 "regexp/prefer-d",
-                "regexp/prefer-d",
                 "regexp/use-ignore-case",
             ],
         )

tests/lib/rules/__snapshots__/prefer-d.ts.eslintsnap

@@ -26,6 +26,9 @@ Output:
 
 
 Test: prefer-d >> invalid
+Options:
+  - insideCharacterClass: d
+
 Code:
   1 | /[^0-9\w]/
     |    ^~~ [1]

tests/lib/rules/prefer-d.ts

@@ -12,6 +12,7 @@ tester.run("prefer-d", rule as any, {
     valid: [
         String.raw`/\d/`,
         String.raw`/[1-9]/`,
+        "/[^0-9\\w]/",
         {
             code: String.raw`/[0-9a-z]/`,
             options: [{ insideCharacterClass: "ignore" }],
@@ -40,7 +41,10 @@ tester.run("prefer-d", rule as any, {
     invalid: [
         "/[0-9]/",
         "/[^0-9]/",
-        "/[^0-9\\w]/",
+        {
+            code: "/[^0-9\\w]/",
+            options: [{ insideCharacterClass: "d" }],
+        },
         `
             const s = "[0-9]"
             new RegExp(s)