Upgrade to RAA v0.5.1 and improve sort-alternatives (#419)

* Upgrade to RAA v0.5.0

* Update to RAA v0.5.1

* Fix issue #416

Author: RunDevelopment

lib/rules/no-useless-assertions.ts

@@ -252,7 +252,7 @@ export default createRule("no-useless-assertions", {
                     const range = getLengthRange(assertion.alternatives)
                     // we only check the first character, so it's only correct if the assertion requires only one
                     // character
-                    if (range && range.max === 1) {
+                    if (range.max === 1) {
                         // require exactness
                         if (
                             firstOf.exact &&

lib/rules/prefer-lookaround.ts

@@ -168,7 +168,7 @@ function getSideEffectsWhenReplacingCapturingGroup(
     /** Checks whether the given element is constant length. */
     function isConstantLength(target: Element): boolean {
         const range = getLengthRange(target)
-        return Boolean(range && range.min === range.max)
+        return range.min === range.max
     }
 }
 

lib/rules/sort-alternatives.ts

@@ -152,6 +152,7 @@ function compareCharSetStrings(
 
 const LONGEST_PREFIX_OPTIONS: GetLongestPrefixOptions = {
     includeAfter: true,
+    onlyInside: true,
     looseGroups: true,
 }
 

package-lock.json

@@ -94,7 +94,7 @@
         "grapheme-splitter": "^1.0.4",
         "jsdoctypeparser": "^9.0.0",
         "refa": "^0.9.0",
-        "regexp-ast-analysis": "^0.4.1",
+        "regexp-ast-analysis": "^0.5.1",
         "regexpp": "^3.2.0",
         "scslre": "^0.1.6"
     }

package.json

@@ -9,7 +9,13 @@ const tester = new RuleTester({
 })
 
 tester.run("sort-alternatives", rule as any, {
-    valid: [String.raw`/\b(?:a|\d+|c|b)\b/`, String.raw`/\b(?:\^|c|b)\b/`],
+    valid: [
+        String.raw`/\b(?:a|\d+|c|b)\b/`,
+        String.raw`/\b(?:\^|c|b)\b/`,
+        String.raw`/^(?:a|ab)a/u`,
+        String.raw`/^(?:a|ab)c/u`,
+        String.raw`/^(?:deg|g?rad|turn)\b/`,
+    ],
     invalid: [
         {
             code: String.raw`/c|b|a/`,