Chores: update eslint config

Author: ota-meshi

.eslintrc.js

@@ -26,6 +26,30 @@ module.exports = {
 
         "no-shadow": "off", // ts bug?
         "@typescript-eslint/no-shadow": "error",
+
+        // https://github.com/ota-meshi/eslint-plugin-regexp/pull/49
+        "no-empty-character-class": "error",
+        "regexp/negation": "error",
+        "regexp/no-dupe-disjunctions": "error",
+        "regexp/no-useless-character-class": "error",
+        "regexp/no-useless-escape": "error",
+        "regexp/no-useless-non-capturing-group": "error",
+        "regexp/no-useless-non-greedy": "error",
+        "regexp/no-useless-range": "error",
+        "regexp/prefer-character-class": "error",
+        "regexp/prefer-range": "error",
+        "regexp/prefer-unicode-codepoint-escapes": "error",
+
+        "regexp/letter-case": [
+            "error",
+            { hexadecimalEscape: "lowercase", controlEscape: "uppercase" },
+        ],
+
+        // others
+        "regexp/order-in-character-class": "error",
+        "regexp/prefer-quantifier": "error",
+        "regexp/prefer-regexp-exec": "error",
+        "regexp/prefer-regexp-test": "error",
     },
     overrides: [
         {

lib/rules/letter-case.ts

@@ -248,7 +248,7 @@ export default createRule("letter-case", {
                     if (/^\\x.+$/u.test(cNode.raw)) {
                         verifyCharacterInHexadecimalEscape(node, cNode)
                     }
-                    if (/^\\c[a-zA-Z]$/u.test(cNode.raw)) {
+                    if (/^\\c[A-Za-z]$/u.test(cNode.raw)) {
                         verifyCharacterInControl(node, cNode)
                     }
                 },

lib/rules/no-useless-character-class.ts

@@ -131,7 +131,7 @@ export default createRule("no-useless-character-class", {
                                 element.type === "CharacterClassRange"
                             ) {
                                 if (
-                                    /^[.*+?${()|[/]$/u.test(text) ||
+                                    /^[$(-+./?[{|]$/u.test(text) ||
                                     (flags.includes("u") && text === "}")
                                 ) {
                                     text = fixerApplyEscape("\\", node) + text

lib/rules/prefer-unicode-codepoint-escapes.ts

@@ -40,7 +40,7 @@ export default createRule("prefer-unicode-codepoint-escapes", {
             return {
                 onCharacterEnter(cNode) {
                     if (cNode.value >= 0x10000) {
-                        if (/^(?:\\u[\da-fA-F]{4}){2}$/.test(cNode.raw)) {
+                        if (/^(?:\\u[\dA-Fa-f]{4}){2}$/.test(cNode.raw)) {
                             context.report({
                                 node,
                                 loc: getRegexpLocation(sourceCode, node, cNode),

lib/utils/regexp-ast.ts

@@ -151,10 +151,7 @@ export function isEqualNodes<N extends Node>(
             return kind
         }
     }
-    if (
-        /(?:\(|\\|\[|\{|\||\+|\?|\*)/.test(a.raw) ||
-        /(?:\(|\\|\[|\{|\||\+|\?|\*)/.test(b.raw)
-    ) {
+    if (/[(*+?[\\{|]/.test(a.raw) || /[(*+?[\\{|]/.test(b.raw)) {
         return EQUALS_CHECKER[a.type](a as never, b as never, shortCircuit)
     }
     return a.raw === b.raw

package.json

@@ -64,7 +64,7 @@
         "eslint-plugin-jsonc": "^1.0.0",
         "eslint-plugin-node": "^11.1.0",
         "eslint-plugin-prettier": "^3.3.1",
-        "eslint-plugin-regexp": "^0.3.0",
+        "eslint-plugin-regexp": "^0.4.0",
         "eslint-plugin-vue": "^7.5.0",
         "eslint-plugin-yml": "^0.7.0",
         "eslint4b": "^7.3.1",

tests/lib/utils/regexp-ast.ts

@@ -4,6 +4,9 @@ eslint-disable
     regexp/no-dupe-characters-character-class,
     regexp/prefer-question-quantifier,
     regexp/prefer-star-quantifier,
+    regexp/prefer-character-class,
+    regexp/prefer-range,
+    regexp/order-in-character-class,
 --------------------------------------------- ignore */
 import assert from "assert"
 import { parseRegExpLiteral } from "regexpp"