Fixed toCharSet ignoring optional flags (#269)

RunDevelopment · web-flow · commit 6608d2a74b88 · 2021-07-07T09:06:38.000+09:00
diff --git a/lib/utils/index.ts b/lib/utils/index.ts
@@ -518,7 +518,7 @@ function buildRegExpHelperBase({
         toCharSet: (node, optionFlags) => {
             if (optionFlags) {
                 // Ignore the cache if the flag is specified.
-                return toCharSet(node, flags)
+                return toCharSet(node, optionFlags)
             }
 
             let charSet = cacheCharSet.get(node)
diff --git a/tests/lib/rules/no-useless-flag.ts b/tests/lib/rules/no-useless-flag.ts
@@ -22,6 +22,7 @@ tester.run("no-useless-flag", rule as any, {
         `/\\b/iu`,
         String.raw`/\x41/i`,
         `/[a-zA-Z]/i`, // in that case you should use the i flag instead of removing it
+        `/\\p{Ll}/iu`,
 
         // m
         `/^foo/m`,

Original file line number	Diff line number	Diff line change
`@@ -518,7 +518,7 @@ function buildRegExpHelperBase({`
`518`	`518`	`toCharSet: (node, optionFlags) => {`
`519`	`519`	`if (optionFlags) {`
`520`	`520`	`// Ignore the cache if the flag is specified.`
`521`		`- return toCharSet(node, flags)`
	`521`	`+ return toCharSet(node, optionFlags)`
`522`	`522`	`}`
`523`	`523`
`524`	`524`	`let charSet = cacheCharSet.get(node)`