Skip to content

Commit 903cced

Browse files
authored
Remove the unused name check from regexp/no-unused-capturing-group rule (#349)
1 parent 22a3613 commit 903cced

File tree

7 files changed

+815
-553
lines changed

7 files changed

+815
-553
lines changed

docs/rules/no-unused-capturing-group.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ var index = '2000-12-31'.search(/(?:\d{4})-(?:\d{2})-(?:\d{2})/) // 0
3939
var replaced = '2000-12-31'.replace(/(\d{4})-(\d{2})-(\d{2})/, 'Date') // "Date"
4040
var replaced = '2000-12-31'.replace(/(\d{4})-(\d{2})-(\d{2})/, '$1/$2') // "2000/12"
4141
var replaced = '2000-12-31'.replace(/(?<y>\d{4})-(?<m>\d{2})-(?<d>\d{2})/u, '$<y>/$<m>') // "2000/12"
42-
var replaced = '2000-12-31'.replace(/(?<y>\d{4})-(?<m>\d{2})-(?<d>\d{2})/u, '$1/$2/$3') // "2000/12/31"
4342
var replaced = '2000-12-31'.replace(/(\d{4})-(\d{2})-(\d{2})/, (_, y, m) => `${y}/${m}`) // "2000/12"
4443

4544
var isDate = /(\d{4})-(\d{2})-(\d{2})/.test('2000-12-31') // true
@@ -76,7 +75,7 @@ Using capturing groups only if the captured text is used makes their usage unamb
7675
```json
7776
{
7877
"regexp/no-unused-capturing-group": ["error", {
79-
"fixable": true
78+
"fixable": false
8079
}]
8180
}
8281
```
@@ -87,10 +86,11 @@ Using capturing groups only if the captured text is used makes their usage unamb
8786

8887
This rule is not fixable by default. Unused capturing groups can indicate a mistake in the code that uses the regex, so changing the regex might not be the right fix. When enabling this option, be sure to carefully check its changes.
8988

90-
9189
## :couple: Related rules
9290

93-
- [regexp/no-useless-dollar-replacements](./no-useless-dollar-replacements.md)
91+
- [regexp/no-useless-dollar-replacements]
92+
93+
[regexp/no-useless-dollar-replacements]: ./no-useless-dollar-replacements.md
9494

9595
## :rocket: Version
9696

0 commit comments

Comments
 (0)