chore: fix CI error (#777)

* chore: fix ci error

* fix

* fix

Author: ota-meshi

.github/workflows/NodeCI.yml

@@ -34,8 +34,6 @@ jobs:
               run: npm ci
             - name: Install ESLint ${{ matrix.eslint }}
               run: npm i -D eslint@${{ matrix.eslint }}
-            - name: Build
-              run: npm run build
             - name: Test
               run: npm test
     test-and-coverage:

lib/utils/ast-utils/pattern-source.ts

@@ -1,5 +1,10 @@
 import type { Rule, AST, SourceCode } from "eslint"
-import type { Expression, Literal, RegExpLiteral } from "estree"
+import type {
+    Expression,
+    Literal,
+    RegExpLiteral,
+    PrivateIdentifier,
+} from "estree"
 import {
     dereferenceOwnedVariable,
     astRangeToLocation,
@@ -266,6 +271,7 @@ export class PatternSource {
         let value = ""
 
         for (const e of flat) {
+            if (e.type === "PrivateIdentifier") return null
             const staticValue = getStaticValue(context, e)
             if (!staticValue) {
                 return null
@@ -433,10 +439,15 @@ export class PatternSource {
  *
  * This will automatically dereference owned constants.
  */
-function flattenPlus(context: Rule.RuleContext, e: Expression): Expression[] {
+function flattenPlus(
+    context: Rule.RuleContext,
+    e: Expression,
+): (Expression | PrivateIdentifier)[] {
     if (e.type === "BinaryExpression" && e.operator === "+") {
         return [
-            ...flattenPlus(context, e.left),
+            ...(e.left.type !== "PrivateIdentifier"
+                ? flattenPlus(context, e.left)
+                : [e.left]),
             ...flattenPlus(context, e.right),
         ]
     }

lib/utils/regexp-ast/is-covered.ts

@@ -481,6 +481,8 @@ function normalizeNodeWithoutCache(
 
         case "Backreference":
         case "Flags":
+        case "ModifierFlags":
+        case "Modifiers":
             return NormalizedOther.fromNode(node)
 
         default:

lib/utils/regexp-ast/is-equals.ts

@@ -141,6 +141,22 @@ const EQUALS_CHECKER: {
     Group(a, b, flags, shortCircuit) {
         return isEqualSet(a.alternatives, b.alternatives, flags, shortCircuit)
     },
+    ModifierFlags(a, b) {
+        return (
+            a.dotAll === b.dotAll &&
+            a.ignoreCase === b.ignoreCase &&
+            a.multiline === b.multiline
+        )
+    },
+    Modifiers(a, b, flags, shortCircuit) {
+        return (
+            isEqualNodes(a.add, b.add, flags, shortCircuit) &&
+            ((a.remove == null && b.remove == null) ||
+                (a.remove != null &&
+                    b.remove != null &&
+                    isEqualNodes(a.remove, b.remove, flags, shortCircuit)))
+        )
+    },
     Pattern(a, b, flags, shortCircuit) {
         return isEqualSet(a.alternatives, b.alternatives, flags, shortCircuit)
     },

lib/utils/type-tracker/jsdoc.ts

@@ -109,7 +109,11 @@ export class JSDoc {
  * Get the JSDoc comment for a given expression node.
  */
 export function getJSDoc(
-    node: ES.Expression | ES.VariableDeclarator | ES.FunctionDeclaration,
+    node:
+        | ES.Expression
+        | ES.VariableDeclarator
+        | ES.FunctionDeclaration
+        | ES.PrivateIdentifier,
     context: Rule.RuleContext,
 ): JSDoc | null {
     const sourceCode = context.sourceCode

lib/utils/type-tracker/tracker.ts

@@ -74,7 +74,10 @@ export function createTypeTracker(context: Rule.RuleContext): TypeTracker {
 
     const { tsNodeMap, checker, usedTS } = getTypeScriptTools(context)
 
-    const cacheTypeInfo = new WeakMap<ES.Expression, TypeInfo | null>()
+    const cacheTypeInfo = new WeakMap<
+        ES.Expression | ES.PrivateIdentifier,
+        TypeInfo | null
+    >()
 
     const tracker: TypeTracker = {
         isString,
@@ -129,7 +132,9 @@ export function createTypeTracker(context: Rule.RuleContext): TypeTracker {
     /**
      * Get the type name from given node.
      */
-    function getType(node: ES.Expression): TypeInfo | null {
+    function getType(
+        node: ES.Expression | ES.PrivateIdentifier,
+    ): TypeInfo | null {
         if (cacheTypeInfo.has(node)) {
             return cacheTypeInfo.get(node) ?? null
         }
@@ -147,7 +152,9 @@ export function createTypeTracker(context: Rule.RuleContext): TypeTracker {
     /**
      * Get the type name from given node.
      */
-    function getTypeWithoutCache(node: ES.Expression): TypeInfo | null {
+    function getTypeWithoutCache(
+        node: ES.Expression | ES.PrivateIdentifier,
+    ): TypeInfo | null {
         if (node.type === "Literal") {
             if (typeof node.value === "string") {
                 return STRING
@@ -511,7 +518,9 @@ export function createTypeTracker(context: Rule.RuleContext): TypeTracker {
     /**
      * Get type from given node by ts types.
      */
-    function getTypeByTs(node: ES.Expression): TypeInfo | null {
+    function getTypeByTs(
+        node: ES.Expression | ES.PrivateIdentifier,
+    ): TypeInfo | null {
         const tsNode = tsNodeMap.get(node)
         const tsType = (tsNode && checker?.getTypeAtLocation(tsNode)) || null
         return tsType && getTypeFromTsType(tsType)

lib/utils/type-tracker/utils.ts

@@ -1,5 +1,4 @@
-import type { Rule } from "eslint"
-import type { Variable } from "eslint-scope"
+import type { Rule, Scope } from "eslint"
 import type * as ES from "estree"
 import * as astUtils from "../ast-utils"
 import * as eslintUtils from "@eslint-community/eslint-utils"
@@ -10,7 +9,7 @@ import * as eslintUtils from "@eslint-community/eslint-utils"
 export function findVariable(
     context: Rule.RuleContext,
     node: ES.Identifier,
-): Variable | null {
+): Scope.Variable | null {
     return astUtils.findVariable(context, node)
 }
 /**