Add test cases for v flag (#643)

ota-meshi · web-flow · commit ae1897a06c52 · 2023-10-04T15:08:57.000+02:00
diff --git a/tests/lib/rules/no-invisible-character.ts b/tests/lib/rules/no-invisible-character.ts
@@ -3,7 +3,7 @@ import rule from "../../../lib/rules/no-invisible-character"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
@@ -22,6 +22,7 @@ tester.run("no-invisible-character", rule as any, {
         "new RegExp(' ')",
         "new RegExp('a')",
         "new RegExp('[ ]')",
+        String.raw`/[\q{\t}]/v`,
     ],
     invalid: [
         {
@@ -104,5 +105,10 @@ tester.run("no-invisible-character", rule as any, {
                 "Unexpected invisible character. Use '\\u200b' instead.",
             ],
         },
+        {
+            code: `/[\\q{\t}]/v`,
+            output: String.raw`/[\q{\t}]/v`,
+            errors: ["Unexpected invisible character. Use '\\t' instead."],
+        },
     ],
 })
diff --git a/tests/lib/rules/no-lazy-ends.ts b/tests/lib/rules/no-lazy-ends.ts
@@ -3,7 +3,7 @@ import rule from "../../../lib/rules/no-lazy-ends"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
@@ -28,6 +28,8 @@ tester.run("no-lazy-ends", rule as any, {
                 sourceType: "script",
             },
         },
+
+        String.raw`/[\q{ab}]?/v.test(str)`,
     ],
     invalid: [
         {
@@ -200,5 +202,16 @@ tester.run("no-lazy-ends", rule as any, {
                 },
             ],
         },
+        {
+            code: String.raw`/[\q{ab|}]??/v.test(str)`,
+            errors: [
+                {
+                    message:
+                        "The quantifier and the quantified element can be removed because the quantifier is lazy and has a minimum of 0.",
+                    line: 1,
+                    column: 2,
+                },
+            ],
+        },
     ],
 })
diff --git a/tests/lib/rules/no-legacy-features.ts b/tests/lib/rules/no-legacy-features.ts
@@ -3,7 +3,7 @@ import rule from "../../../lib/rules/no-legacy-features"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
diff --git a/tests/lib/rules/no-missing-g-flag.ts b/tests/lib/rules/no-missing-g-flag.ts
@@ -3,7 +3,7 @@ import rule from "../../../lib/rules/no-missing-g-flag"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
@@ -52,6 +52,11 @@ tester.run("no-missing-g-flag", rule as any, {
         const s = 'foo'
         const ret = s.replaceAll(new RegExp('foo', unknown), 'bar')
         `,
+        // ES2024
+        String.raw`
+        const s = 'foo'
+        const ret = s.replaceAll(/[\q{foo}]/gv, 'bar')
+        `,
     ],
     invalid: [
         {
@@ -233,5 +238,25 @@ tester.run("no-missing-g-flag", rule as any, {
                 },
             ],
         },
+        {
+            // ES2024
+            code: String.raw`
+            const s = 'foo'
+            const ret = s.replaceAll(/[\q{foo}]/v, 'bar')
+            `,
+            output: String.raw`
+            const s = 'foo'
+            const ret = s.replaceAll(/[\q{foo}]/vg, 'bar')
+            `,
+            options: [{ strictTypes: false }],
+            errors: [
+                {
+                    message:
+                        "The pattern given to the argument of `String#replaceAll()` requires the `g` flag, but is missing it.",
+                    line: 3,
+                    column: 38,
+                },
+            ],
+        },
     ],
 })
diff --git a/tests/lib/rules/no-obscure-range.ts b/tests/lib/rules/no-obscure-range.ts
@@ -3,7 +3,7 @@ import rule from "../../../lib/rules/no-obscure-range"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
@@ -23,6 +23,7 @@ tester.run("no-obscure-range", rule as any, {
                 },
             },
         },
+        "/[[0-9]--[6-8]]/v",
     ],
     invalid: [
         {
@@ -125,5 +126,16 @@ tester.run("no-obscure-range", rule as any, {
                 },
             ],
         },
+        {
+            code: String.raw`/[[ -\/]--+]/v`,
+            errors: [
+                {
+                    message:
+                        "Unexpected obscure character range. The characters of ' -\\/' (U+0020 - U+002f) are not obvious.",
+                    line: 1,
+                    column: 4,
+                },
+            ],
+        },
     ],
 })
diff --git a/tests/lib/rules/no-octal.ts b/tests/lib/rules/no-octal.ts
@@ -3,13 +3,13 @@ import rule from "../../../lib/rules/no-octal"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
 
 tester.run("no-octal", rule as any, {
-    valid: ["/\\0/", "/[\\7]/", "/[\\1-\\4]/"],
+    valid: ["/\\0/", "/[\\7]/", "/[\\1-\\4]/", String.raw`/[\q{\0}]/v`],
     invalid: [
         {
             code: "/\\07/",
diff --git a/tests/lib/rules/no-optional-assertion.ts b/tests/lib/rules/no-optional-assertion.ts
@@ -3,7 +3,7 @@ import rule from "../../../lib/rules/no-optional-assertion"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
@@ -15,6 +15,7 @@ tester.run("no-optional-assertion", rule as any, {
         String.raw`/(?:a|(?:\b|a)+)?/`,
         String.raw`/fo(?:o\b)/`,
         String.raw`/fo(?:o\b){1}/`,
+        String.raw`/(?:(?=[\q{a}]))/v`,
     ],
     invalid: [
         {
@@ -89,5 +90,16 @@ tester.run("no-optional-assertion", rule as any, {
                 },
             ],
         },
+        {
+            code: String.raw`/(?:(?=[\q{a}]))?/v`,
+            errors: [
+                {
+                    message:
+                        "This assertion effectively optional and does not change the pattern. Either remove the assertion or change the parent quantifier '?'.",
+                    line: 1,
+                    column: 5,
+                },
+            ],
+        },
     ],
 })
diff --git a/tests/lib/rules/no-potentially-useless-backreference.ts b/tests/lib/rules/no-potentially-useless-backreference.ts
@@ -3,7 +3,7 @@ import rule from "../../../lib/rules/no-potentially-useless-backreference"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
@@ -14,6 +14,7 @@ tester.run("no-potentially-useless-backreference", rule as any, {
         String.raw`/(a*)(?:a|\1)/`,
         String.raw`/(a)+\1/`,
         String.raw`/(?=(a))\1/`,
+        String.raw`/([\q{a}])\1/v`,
 
         // done by regexp/no-useless-backreference
         String.raw`/(a+)b|\1/`,
@@ -84,5 +85,16 @@ tester.run("no-potentially-useless-backreference", rule as any, {
                 },
             ],
         },
+        {
+            code: String.raw`/(?:([\q{a}])|b)\1/v`,
+            errors: [
+                {
+                    message:
+                        "Some paths leading to the backreference do not go through the referenced capturing group or the captured text might be reset before reaching the backreference.",
+                    line: 1,
+                    column: 17,
+                },
+            ],
+        },
     ],
 })
diff --git a/tests/lib/rules/no-standalone-backslash.ts b/tests/lib/rules/no-standalone-backslash.ts
@@ -3,13 +3,13 @@ import rule from "../../../lib/rules/no-standalone-backslash"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
 
 tester.run("no-standalone-backslash", rule as any, {
-    valid: [String.raw`/\cX/`],
+    valid: [String.raw`/\cX/`, String.raw`/[[\cA-\cZ]--\cX]/v`],
     invalid: [
         {
             code: String.raw`/\c/`,
diff --git a/tests/lib/rules/no-super-linear-backtracking.ts b/tests/lib/rules/no-super-linear-backtracking.ts
@@ -3,7 +3,7 @@ import rule from "../../../lib/rules/no-super-linear-backtracking"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
@@ -13,6 +13,7 @@ tester.run("no-super-linear-backtracking", rule as any, {
         String.raw`/regexp/`,
         String.raw`/a+b+a+b+/`,
         String.raw`/\w+\b[\w-]+/`,
+        String.raw`/[\q{ab}]*[\q{ab}]*$/v`, // Limitation of scslre
     ],
     invalid: [
         // self
@@ -53,5 +54,12 @@ tester.run("no-super-linear-backtracking", rule as any, {
                 "The quantifier '\\w+' can exchange characters with '\\w+'. Using any string accepted by /b+/, this can be exploited to cause at least polynomial backtracking. This might cause exponential backtracking.",
             ],
         },
+        {
+            code: String.raw`/[\q{a}]*b?[\q{a}]+$/v`,
+            output: String.raw`/(?:[\q{a}]+(?:b[\q{a}]+)?|b[\q{a}]+)$/v`,
+            errors: [
+                "The quantifier '[\\q{a}]*' can exchange characters with '[\\q{a}]+'. Using any string accepted by /a+/, this can be exploited to cause at least polynomial backtracking. This might cause exponential backtracking.",
+            ],
+        },
     ],
 })
diff --git a/tests/lib/rules/no-super-linear-move.ts b/tests/lib/rules/no-super-linear-move.ts
@@ -3,7 +3,7 @@ import rule from "../../../lib/rules/no-super-linear-move"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
@@ -26,6 +26,7 @@ tester.run("no-super-linear-move", rule as any, {
         },
         { code: String.raw`/a*b/.source`, options: [{ ignorePartial: true }] },
         { code: String.raw`/a*b/y`, options: [{ ignoreSticky: true }] },
+        String.raw`/[\q{abc}]+/v`,
     ],
     invalid: [
         {
@@ -80,5 +81,11 @@ tester.run("no-super-linear-move", rule as any, {
                 "Any attack string /a+/ plus some rejecting suffix will cause quadratic runtime because of this quantifier.",
             ],
         },
+        {
+            code: String.raw`/[\q{abc}]+a/v`,
+            errors: [
+                "Any attack string /(?:abc)+/ plus some rejecting suffix will cause quadratic runtime because of this quantifier.",
+            ],
+        },
     ],
 })
diff --git a/tests/lib/rules/no-trivially-nested-assertion.ts b/tests/lib/rules/no-trivially-nested-assertion.ts
@@ -3,7 +3,7 @@ import rule from "../../../lib/rules/no-trivially-nested-assertion"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
@@ -22,6 +22,9 @@ tester.run("no-trivially-nested-assertion", rule as any, {
         // guaranteed to be reset, so we can't transform them into one
         // non-negated lookaround
         `/(?!(?!(a)))/`,
+
+        // ES2024
+        String.raw`/(?=[\q{$}])/v`,
     ],
     invalid: [
         {
diff --git a/tests/lib/rules/no-trivially-nested-quantifier.ts b/tests/lib/rules/no-trivially-nested-quantifier.ts
@@ -3,13 +3,19 @@ import rule from "../../../lib/rules/no-trivially-nested-quantifier"
 
 const tester = new RuleTester({
     parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: "latest",
         sourceType: "module",
     },
 })
 
 tester.run("no-trivially-nested-quantifier", rule as any, {
-    valid: [`/(a?)+/`, `/(?:a{2})+/`, `/(?:a{3,4})+/`, `/(?:a+?)+/`],
+    valid: [
+        `/(a?)+/`,
+        `/(?:a{2})+/`,
+        `/(?:a{3,4})+/`,
+        `/(?:a+?)+/`,
+        String.raw`/(?:[\q{a}])+/v`,
+    ],
     invalid: [
         {
             code: String.raw`/(?:a?)+/`,
@@ -110,5 +116,12 @@ tester.run("no-trivially-nested-quantifier", rule as any, {
                 { message: "This nested quantifier can be simplified to '?'." },
             ],
         },
+        {
+            code: String.raw`/(?:[\q{a}]+)+/v`,
+            output: String.raw`/[\q{a}]+/v`,
+            errors: [
+                "These two quantifiers are trivially nested and can be replaced with '+'.",
+            ],
+        },
     ],
 })
diff --git a/tests/lib/rules/no-unused-capturing-group.ts b/tests/lib/rules/no-unused-capturing-group.ts
