Add regexp/no-invisible-character rule and regexp/no-useless-two-nums-quantifier rule and refactor (#2)

Author: ota-meshi

README.md

@@ -63,7 +63,8 @@ module.exports = {
 
 This plugin provides one config:
 
-- `plugin:regexp/recommended` ... This is the recommended configuration for this plugin.
+- `plugin:regexp/recommended` ... This is the recommended configuration for this plugin.  
+  See [lib/configs/recommended.ts](https://github.com/ota-meshi/eslint-plugin-regexp/blob/master/lib/configs/recommended.ts) for details.
 
 <!--USAGE_SECTION_END-->
 
@@ -84,8 +85,10 @@ The rules with the following star :star: are included in the `plugin:regexp/reco
 | [regexp/no-empty-group](https://ota-meshi.github.io/eslint-plugin-regexp/rules/no-empty-group.html) | disallow empty group | :star: |
 | [regexp/no-empty-lookarounds-assertion](https://ota-meshi.github.io/eslint-plugin-regexp/rules/no-empty-lookarounds-assertion.html) | disallow empty lookahead assertion or empty lookbehind assertion | :star: |
 | [regexp/no-escape-backspace](https://ota-meshi.github.io/eslint-plugin-regexp/rules/no-escape-backspace.html) | disallow escape backspace (`[\b]`) | :star: |
+| [regexp/no-invisible-character](https://ota-meshi.github.io/eslint-plugin-regexp/rules/no-invisible-character.html) | disallow invisible raw character | :star::wrench: |
 | [regexp/no-octal](https://ota-meshi.github.io/eslint-plugin-regexp/rules/no-octal.html) | disallow octal escape sequence | :star: |
 | [regexp/no-useless-exactly-quantifier](https://ota-meshi.github.io/eslint-plugin-regexp/rules/no-useless-exactly-quantifier.html) | disallow unnecessary exactly quantifier | :star: |
+| [regexp/no-useless-two-nums-quantifier](https://ota-meshi.github.io/eslint-plugin-regexp/rules/no-useless-two-nums-quantifier.html) | disallow unnecessary `{n,m}` quantifier | :star: |
 | [regexp/prefer-d](https://ota-meshi.github.io/eslint-plugin-regexp/rules/prefer-d.html) | enforce using `\d` | :star::wrench: |
 | [regexp/prefer-plus-quantifier](https://ota-meshi.github.io/eslint-plugin-regexp/rules/prefer-plus-quantifier.html) | enforce using `+` quantifier | :star::wrench: |
 | [regexp/prefer-question-quantifier](https://ota-meshi.github.io/eslint-plugin-regexp/rules/prefer-question-quantifier.html) | enforce using `?` quantifier | :star::wrench: |

docs/rules/README.md

@@ -17,8 +17,10 @@ The rules with the following star :star: are included in the `plugin:regexp/reco
 | [regexp/no-empty-group](./no-empty-group.md) | disallow empty group | :star: |
 | [regexp/no-empty-lookarounds-assertion](./no-empty-lookarounds-assertion.md) | disallow empty lookahead assertion or empty lookbehind assertion | :star: |
 | [regexp/no-escape-backspace](./no-escape-backspace.md) | disallow escape backspace (`[\b]`) | :star: |
+| [regexp/no-invisible-character](./no-invisible-character.md) | disallow invisible raw character | :star::wrench: |
 | [regexp/no-octal](./no-octal.md) | disallow octal escape sequence | :star: |
 | [regexp/no-useless-exactly-quantifier](./no-useless-exactly-quantifier.md) | disallow unnecessary exactly quantifier | :star: |
+| [regexp/no-useless-two-nums-quantifier](./no-useless-two-nums-quantifier.md) | disallow unnecessary `{n,m}` quantifier | :star: |
 | [regexp/prefer-d](./prefer-d.md) | enforce using `\d` | :star::wrench: |
 | [regexp/prefer-plus-quantifier](./prefer-plus-quantifier.md) | enforce using `+` quantifier | :star::wrench: |
 | [regexp/prefer-question-quantifier](./prefer-question-quantifier.md) | enforce using `?` quantifier | :star::wrench: |

docs/rules/match-any.md

@@ -22,14 +22,14 @@ e.g. `[\s\S]`, `[^]`, `/./s` (dotAll) and more.
 /* eslint regexp/match-any: "error" */
 
 /* ✓ GOOD */
-var foo = /[\s\S]/
-var foo = /./s
+var foo = /[\s\S]/;
+var foo = /./s;
 
 /* ✗ BAD */
-var foo = /[\S\s]/
-var foo = /[^]/
-var foo = /[\d\D]/
-var foo = /[\w\W]/
+var foo = /[\S\s]/;
+var foo = /[^]/;
+var foo = /[\d\D]/;
+var foo = /[\w\W]/;
 ```
 
 </eslint-code-block>
@@ -55,14 +55,14 @@ var foo = /[\w\W]/
 /* eslint regexp/match-any: ["error", { "allows": ["[^]"] }] */
 
 /* ✓ GOOD */
-var foo = /[^]/
+var foo = /[^]/;
 
 /* ✗ BAD */
-var foo = /[\s\S]/
-var foo = /[\S\s]/
-var foo = /./s
-var foo = /[\d\D]/
-var foo = /[\w\W]/
+var foo = /[\s\S]/;
+var foo = /[\S\s]/;
+var foo = /./s;
+var foo = /[\d\D]/;
+var foo = /[\w\W]/;
 ```
 
 </eslint-code-block>

docs/rules/no-assertion-capturing-group.md

@@ -20,15 +20,15 @@ This rule reports capturing group that captures assertions.
 /* eslint regexp/no-assertion-capturing-group: "error" */
 
 /* ✓ GOOD */
-var foo = /(a)/
-var foo = /a(?:\b)/
-var foo = /a(?:$)/
-var foo = /(?:^)a/
+var foo = /(a)/;
+var foo = /a(?:\b)/;
+var foo = /a(?:$)/;
+var foo = /(?:^)a/;
 
 /* ✗ BAD */
-var foo = /a(\b)/
-var foo = /a($)/
-var foo = /(^)a/
+var foo = /a(\b)/;
+var foo = /a($)/;
+var foo = /(^)a/;
 ```
 
 </eslint-code-block>

docs/rules/no-dupe-characters-character-class.md

@@ -13,7 +13,7 @@ description: "disallow duplicate characters in the RegExp character class"
 Because multiple same character classes in regular expressions only one is useful, they might be typing mistakes.
 
 ```js
-var foo = /\\(\\)/
+var foo = /\\(\\)/;
 ```
 
 ## :book: Rule Details
@@ -26,18 +26,18 @@ This rule disallows duplicate characters in the RegExp character class.
 /* eslint regexp/no-dupe-characters-character-class: "error" */
 
 /* ✓ GOOD */
-var foo = /[\(\)]/
+var foo = /[\(\)]/;
 
-var foo = /[a-z\s]/
+var foo = /[a-z\s]/;
 
-var foo = /[\w]/
+var foo = /[\w]/;
 
 /* ✗ BAD */
-var foo = /[\\(\\)]/
+var foo = /[\\(\\)]/;
 //          ^^ ^^        "\\" are duplicated
-var foo = /[a-z\\s]/
+var foo = /[a-z\\s]/;
 //          ^^^  ^       "s" are duplicated
-var foo = /[\w0-9]/
+var foo = /[\w0-9]/;
 //          ^^^^^        "0-9" are duplicated
 ```
 

docs/rules/no-empty-group.md

@@ -20,16 +20,16 @@ This rule reports empty groups.
 /* eslint regexp/no-empty-group: "error" */
 
 /* ✓ GOOD */
-var foo = /(a)/
-var foo = /(?:a)/
+var foo = /(a)/;
+var foo = /(?:a)/;
 
 /* ✗ BAD */
 // capturing group
-var foo = /()/
-var foo = /(|)/
+var foo = /()/;
+var foo = /(|)/;
 // non-capturing group
-var foo = /(?:)/
-var foo = /(?:|)/
+var foo = /(?:)/;
+var foo = /(?:|)/;
 ```
 
 </eslint-code-block>

docs/rules/no-empty-lookarounds-assertion.md

@@ -20,16 +20,16 @@ This rule reports empty lookahead assertion or empty lookbehind assertion.
 /* eslint regexp/no-empty-lookarounds-assertion: "error" */
 
 /* ✓ GOOD */
-var foo = /x(?=y)/
-var foo = /x(?!y)/
-var foo = /(?<=y)x/
-var foo = /(?<!y)x/
+var foo = /x(?=y)/;
+var foo = /x(?!y)/;
+var foo = /(?<=y)x/;
+var foo = /(?<!y)x/;
 
 /* ✗ BAD */
-var foo = /x(?=)/
-var foo = /x(?!)/
-var foo = /(?<=)x/
-var foo = /(?<!)x/
+var foo = /x(?=)/;
+var foo = /x(?!)/;
+var foo = /(?<=)x/;
+var foo = /(?<!)x/;
 ```
 
 </eslint-code-block>

docs/rules/no-escape-backspace.md

@@ -21,13 +21,13 @@ The word boundaries (`\b`) and the escape backspace (`[\b]`) are indistinguishab
 /* eslint regexp/no-escape-backspace: "error" */
 
 /* ✓ GOOD */
-var foo = /\b/
-var foo = /\u0008/
-var foo = /\cH/
-var foo = /\x08/
+var foo = /\b/;
+var foo = /\u0008/;
+var foo = /\cH/;
+var foo = /\x08/;
 
 /* ✗ BAD */
-var foo = /[\b]/
+var foo = /[\b]/;
 ```
 
 </eslint-code-block>

docs/rules/no-invisible-character.md

@@ -0,0 +1,46 @@
+---
+pageClass: "rule-details"
+sidebarDepth: 0
+title: "regexp/no-invisible-character"
+description: "disallow invisible raw character"
+---
+# regexp/no-invisible-character
+
+> disallow invisible raw character
+
+- :gear: This rule is included in `"plugin:regexp/recommended"`.
+- :wrench: The `--fix` option on the [command line](https://eslint.org/docs/user-guide/command-line-interface#fixing-problems) can automatically fix some of the problems reported by this rule.
+
+## :book: Rule Details
+
+This rule disallows using invisible characters other than SPACE (`U+0020`) without using escapes.
+
+<eslint-code-block fix>
+
+```js
+/* eslint regexp/no-invisible-character: "error" */
+
+/* ✓ GOOD */
+var foo = /\t/;
+var foo = /\v/;
+var foo = /\f/;
+var foo = /\u3000/;
+var foo = / /; // SPACE (`U+0020`)
+
+/* ✗ BAD */
+var foo = /	/;
+var foo = //;
+var foo = //;
+var foo = /　/;
+```
+
+</eslint-code-block>
+
+## :wrench: Options
+
+Nothing.
+
+## Implementation
+
+- [Rule source](https://github.com/ota-meshi/eslint-plugin-regexp/blob/master/lib/rules/no-invisible-character.ts)
+- [Test source](https://github.com/ota-meshi/eslint-plugin-regexp/blob/master/tests/lib/rules/no-invisible-character.js)

docs/rules/no-octal.md

@@ -22,11 +22,11 @@ This rule reports octal escape.
 /* eslint regexp/no-octal: "error" */
 
 /* ✓ GOOD */
-var foo = /\0/
-var foo = /=/
+var foo = /\0/;
+var foo = /=/;
 
 /* ✗ BAD */
-var foo = /\075/
+var foo = /\075/;
 ```
 
 </eslint-code-block>