Skip to content

Correct capturing group not found grammar #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ota-meshi merged 2 commits into from
Nov 14, 2024
Merged

Correct capturing group not found grammar #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d97db1d
Corrected capturing group not found grammar
adamlui Nov 14, 2024
b2bd4b2
Create tough-planes-smell.md
ota-meshi Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tough-planes-smell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-regexp": patch
---

fix(regexp/no-useless-dollar-replacements): Correct capturing group not found grammar
4 changes: 2 additions & 2 deletions lib/rules/no-useless-dollar-replacements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ export default createRule("no-useless-dollar-replacements", {
numberRef:
"'${{ refText }}' replacement will insert '${{ refText }}' because there are less than {{ num }} capturing groups. Use '$$' if you want to escape '$'.",
numberRefCapturingNotFound:
"'${{ refText }}' replacement will insert '${{ refText }}' because capturing group does not found. Use '$$' if you want to escape '$'.",
"'${{ refText }}' replacement will insert '${{ refText }}' because capturing group is not found. Use '$$' if you want to escape '$'.",
namedRef:
"'$<{{ refText }}>' replacement will be ignored because the named capturing group is not found. Use '$$' if you want to escape '$'.",
namedRefNamedCapturingNotFound:
"'$<{{ refText }}>' replacement will insert '$<{{ refText }}>' because named capturing group does not found. Use '$$' if you want to escape '$'.",
"'$<{{ refText }}>' replacement will insert '$<{{ refText }}>' because named capturing group is not found. Use '$$' if you want to escape '$'.",
},
type: "suggestion", // "problem",
},
Expand Down
4 changes: 2 additions & 2 deletions tests/lib/rules/__snapshots__/no-useless-dollar-replacements.ts.eslintsnap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Code:
| ^~ [1]
4 |

[1] '$1' replacement will insert '$1' because capturing group does not found. Use '$$' if you want to escape '$'.
[1] '$1' replacement will insert '$1' because capturing group is not found. Use '$$' if you want to escape '$'.
---


Expand All @@ -73,7 +73,7 @@ Code:
| ^~~~ [1]
3 |

[1] '$<a>' replacement will insert '$<a>' because named capturing group does not found. Use '$$' if you want to escape '$'.
[1] '$<a>' replacement will insert '$<a>' because named capturing group is not found. Use '$$' if you want to escape '$'.
---


Expand Down