fix: adjust cross-rate price feed tests to ensure fresh price round data

Author: O1ahmad

.github/workflows/release.yml

@@ -18,4 +18,3 @@ jobs:
       - uses: go-semantic-release/action@2e9dc4247a6004f8377781bef4cb9dad273a741f # v1.24.1
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
-          force-bump-patch-version: true # ensure patch version updates trigger releases

test/infrastructure/CrossRatePriceFeed.t.sol

@@ -38,9 +38,12 @@ contract CrossRatePriceFeedTest is Test {
         (,,, uint256 numeratorUpdatedAt,) = usdcUsdFeed.latestRoundData();
         (,,, uint256 denominatorUpdatedAt,) = ethUsdFeed.latestRoundData();
 
-        // Warp to the later of the two update times to ensure both are fresh
-        uint256 latestUpdate = numeratorUpdatedAt > denominatorUpdatedAt ? numeratorUpdatedAt : denominatorUpdatedAt;
-        vm.warp(latestUpdate);
+        // For both to be fresh: block.timestamp <= updatedAt + heartbeat for each        // Warp to min(numeratorUpdatedAt + heartbeat, denominatorUpdatedAt + heartbeat) - 1
+        uint256 numeratorExpiry = numeratorUpdatedAt + USDC_USD_HEARTBEAT;
+        uint256 denominatorExpiry = denominatorUpdatedAt + ETH_USD_HEARTBEAT;
+        uint256 minExpiry = numeratorExpiry < denominatorExpiry ? numeratorExpiry : denominatorExpiry;
+
+        vm.warp(minExpiry - 1);
     }
 
     /// @notice test constructor reverts with zero numerator feed