Skip to content

Commit 03b3ac4

Browse files
removed redundant code
1 parent 6038b53 commit 03b3ac4

File tree

1 file changed

+1
-27
lines changed

1 file changed

+1
-27
lines changed

cpp/APLRRegressor.h

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -810,33 +810,7 @@ void APLRRegressor::add_necessary_given_terms_to_interaction(Term &interaction,
810810
break;
811811
}
812812

813-
bool stricter_given_term_exists{false};
814-
for (size_t col2 = 0; col2 < existing_model_term.given_terms.size(); ++col2)
815-
{
816-
bool is_other_given_term{col2!=col};
817-
if(is_other_given_term)
818-
{
819-
bool same_base_term{existing_model_term.given_terms[col].base_term == existing_model_term.given_terms[col2].base_term};
820-
bool same_direction{existing_model_term.given_terms[col].direction_right == existing_model_term.given_terms[col2].direction_right};
821-
bool finite_split_point{std::isfinite(existing_model_term.given_terms[col].split_point) && std::isfinite(existing_model_term.given_terms[col2].split_point)};
822-
if(same_base_term && same_direction && finite_split_point)
823-
{
824-
bool direction_right{existing_model_term.given_terms[col].direction_right};
825-
if(direction_right)
826-
{
827-
stricter_given_term_exists = std::isless(existing_model_term.given_terms[col].split_point, existing_model_term.given_terms[col2].split_point);
828-
}
829-
else
830-
{
831-
stricter_given_term_exists = std::isgreater(existing_model_term.given_terms[col].split_point, existing_model_term.given_terms[col2].split_point);
832-
}
833-
if(stricter_given_term_exists)
834-
break;
835-
}
836-
}
837-
}
838-
839-
if(given_term_provides_an_unique_zero && !stricter_given_term_exists)
813+
if(given_term_provides_an_unique_zero)
840814
interaction.given_terms.push_back(existing_model_term.given_terms[col]);
841815
}
842816
}

0 commit comments

Comments
 (0)