refactor

mathias-von-ottenbreit · mathias-von-ottenbreit · commit 04a316f1a18d · 2022-10-20T22:04:00.000+02:00
diff --git a/cpp/APLRRegressor.h b/cpp/APLRRegressor.h
@@ -450,7 +450,8 @@ VectorXd APLRRegressor::differentiate_predictions()
         return 1.0/4.0 * (linear_predictor_current.array()/2.0).cosh().array().pow(-2);
     else if(link_function=="log")
     {
-        return (linear_predictor_current.array()-linear_predictor_current.maxCoeff()).array().exp();
+        double scaling{linear_predictor_current.maxCoeff()};
+        return (linear_predictor_current.array()-scaling).array().exp();
     }
     else if(link_function=="tweedie")
     {

Original file line number	Diff line number	Diff line change
`@@ -450,7 +450,8 @@ VectorXd APLRRegressor::differentiate_predictions()`
`450`	`450`	`return 1.0/4.0 * (linear_predictor_current.array()/2.0).cosh().array().pow(-2);`
`451`	`451`	`else if(link_function=="log")`
`452`	`452`	`{`
`453`		`- return (linear_predictor_current.array()-linear_predictor_current.maxCoeff()).array().exp();`
	`453`	`+ double scaling{linear_predictor_current.maxCoeff()};`
	`454`	`+ return (linear_predictor_current.array()-scaling).array().exp();`
`454`	`455`	`}`
`455`	`456`	`else if(link_function=="tweedie")`
`456`	`457`	`{`