Skip to content

Commit 11e268e

Browse files
created possibility to have bin in the right end
1 parent 7244a98 commit 11e268e

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

cpp/term.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -367,14 +367,16 @@ void Term::setup_bins()
367367
bins_start_index.push_back(0);
368368
if(bins>1)
369369
{
370-
for (size_t i = min_observations_in_split-1; i <= max_index+1-min_observations_in_split; ++i) //for each observation in an allowable range
370+
size_t start_row{min_observations_in_split-1};
371+
size_t end_row{max_index+1-min_observations_in_split};
372+
for (size_t i = start_row; i <= end_row; ++i)
371373
{
372374
size_t last_bin_start_index{bins_start_index[bins_start_index.size()-1]};
373-
bool eligible_on_spacing_between_observations{i >= last_bin_start_index + observations_in_bin || values_sorted_unique.size()<=bins};
375+
bool eligible_on_spacing_between_observations{i >= last_bin_start_index + observations_in_bin || values_sorted_unique.size()<=bins || i == start_row || i == end_row};
374376
bool eligible_on_unique_numbers{i>0 && !check_if_approximately_equal(sorted_vectors.values_sorted[i],sorted_vectors.values_sorted[i-1])};
375377

376378
bool create_bin{eligible_on_spacing_between_observations && eligible_on_unique_numbers};
377-
if(create_bin)
379+
if(create_bin)
378380
{
379381
bins_start_index.push_back(i);
380382
}

0 commit comments

Comments
 (0)