bugfix wip

mathias-von-ottenbreit · mathias-von-ottenbreit · commit 1f393043b4b1 · 2022-06-24T23:38:01.000+02:00
diff --git a/cpp/APLRRegressor.h b/cpp/APLRRegressor.h
@@ -287,11 +287,12 @@ void APLRRegressor::initialize()
     for (size_t i = 0; i < static_cast<size_t>(X_train.cols()); ++i)
     {
         bool term_has_one_unique_value{check_if_base_term_has_only_one_unique_value(i)};
-        if(!term_has_one_unique_value)
+        Term copy_of_base_term{Term(i)};
+        if(term_has_one_unique_value)
         {
-            Term copy_of_base_term{Term(i)};
-            add_term_to_terms_eligible_current(copy_of_base_term);
+            copy_of_base_term.ineligible_boosting_steps=std::numeric_limits<size_t>::max();
         }
+        add_term_to_terms_eligible_current(copy_of_base_term);
     }
 
     predictions_current=VectorXd::Constant(y_train.size(),0);

Original file line number	Diff line number	Diff line change
`@@ -287,11 +287,12 @@ void APLRRegressor::initialize()`
`287`	`287`	`for (size_t i = 0; i < static_cast<size_t>(X_train.cols()); ++i)`
`288`	`288`	`{`
`289`	`289`	`bool term_has_one_unique_value{check_if_base_term_has_only_one_unique_value(i)};`
`290`		`- if(!term_has_one_unique_value)`
	`290`	`+ Term copy_of_base_term{Term(i)};`
	`291`	`+ if(term_has_one_unique_value)`
`291`	`292`	`{`
`292`		`- Term copy_of_base_term{Term(i)};`
`293`		`- add_term_to_terms_eligible_current(copy_of_base_term);`
	`293`	`+ copy_of_base_term.ineligible_boosting_steps=std::numeric_limits<size_t>::max();`
`294`	`294`	`}`
	`295`	`+ add_term_to_terms_eligible_current(copy_of_base_term);`
`295`	`296`	`}`
`296`	`297`
`297`	`298`	`predictions_current=VectorXd::Constant(y_train.size(),0);`