more thorough cleanup

Author: mathias-von-ottenbreit

cpp/APLRRegressor.h

@@ -422,7 +422,7 @@ void APLRRegressor::determine_interactions_to_consider()
                 if(!(terms[sorted_latest_split_point_errors_indices[i]]==interaction))
                 {
                     interaction.given_terms.push_back(terms[sorted_latest_split_point_errors_indices[i]]);
-                    interaction.given_terms[interaction.given_terms.size()-1].coefficient_steps.resize(0); //freeing memory
+                    interaction.given_terms[interaction.given_terms.size()-1].clean_up_when_this_term_was_added_as_a_given_predictor();
                     bool already_exists{false};
                     for (size_t k = 0; k < terms_eligible_current.size(); ++k)
                     {

cpp/term.h

@@ -55,6 +55,7 @@ class Term
     void estimate_coefficient_and_error_on_all_data();
     void clean_up_after_estimate_split_point();
     void clean_up_after_fit();
+    void clean_up_when_this_term_was_added_as_a_given_predictor();
 
 public:
     //fields
@@ -604,6 +605,12 @@ void Term::clean_up_after_fit()
     sample_weight_discretized.resize(0);
 }
 
+void Term::clean_up_when_this_term_was_added_as_a_given_predictor()
+{
+    clean_up_after_fit();
+    coefficient_steps.resize(0);
+}
+
 VectorXd Term::calculate_prediction_contribution(const MatrixXd &X)
 {
     VectorXd values{calculate(X)};