fixed handling of variables with one unique value

mathias-von-ottenbreit · mathias-von-ottenbreit · commit 22bed154dfec · 2022-06-25T08:30:20.000+02:00
diff --git a/cpp/APLRRegressor.h b/cpp/APLRRegressor.h
@@ -288,11 +288,11 @@ void APLRRegressor::initialize()
     {
         bool term_has_one_unique_value{check_if_base_term_has_only_one_unique_value(i)};
         Term copy_of_base_term{Term(i)};
+        add_term_to_terms_eligible_current(copy_of_base_term);
         if(term_has_one_unique_value)
         {
-            copy_of_base_term.ineligible_boosting_steps=std::numeric_limits<size_t>::max();
+            terms_eligible_current[terms_eligible_current.size()-1].ineligible_boosting_steps=std::numeric_limits<size_t>::max();
         }
-        add_term_to_terms_eligible_current(copy_of_base_term);
     }
 
     predictions_current=VectorXd::Constant(y_train.size(),0);

Original file line number	Diff line number	Diff line change
`@@ -288,11 +288,11 @@ void APLRRegressor::initialize()`
`288`	`288`	`{`
`289`	`289`	`bool term_has_one_unique_value{check_if_base_term_has_only_one_unique_value(i)};`
`290`	`290`	`Term copy_of_base_term{Term(i)};`
	`291`	`+ add_term_to_terms_eligible_current(copy_of_base_term);`
`291`	`292`	`if(term_has_one_unique_value)`
`292`	`293`	`{`
`293`		`- copy_of_base_term.ineligible_boosting_steps=std::numeric_limits<size_t>::max();`
	`294`	`+ terms_eligible_current[terms_eligible_current.size()-1].ineligible_boosting_steps=std::numeric_limits<size_t>::max();`
`294`	`295`	`}`
`295`		`- add_term_to_terms_eligible_current(copy_of_base_term);`
`296`	`296`	`}`
`297`	`297`
`298`	`298`	`predictions_current=VectorXd::Constant(y_train.size(),0);`