calculating discretized beta using sample_weight_discretized

mathias-von-ottenbreit · mathias-von-ottenbreit · commit 56242bbcc455 · 2022-06-16T09:00:26.000+02:00
diff --git a/cpp/term.h b/cpp/term.h
@@ -532,16 +532,8 @@ void Term::calculate_coefficient_and_error_on_discretized_data(bool direction_ri
     double xwy{0};
     for (size_t i = index_start; i <= index_end; ++i)
     {
-        if(sample_weight_discretized.size()>0)
-        {
-            xwx+=values_sorted[i]*values_sorted[i]*sample_weight_discretized[i];
-            xwy+=values_sorted[i]*y_discretized[i]*sample_weight_discretized[i];
-        }
-        else
-        {
-            xwx+=values_sorted[i]*values_sorted[i];
-            xwy+=values_sorted[i]*y_discretized[i];
-        }
+        xwx+=values_sorted[i]*values_sorted[i]*sample_weight_discretized[i];
+        xwy+=values_sorted[i]*y_discretized[i]*sample_weight_discretized[i];
     }
     if(xwx!=0)
     {

Original file line number	Diff line number	Diff line change
`@@ -532,16 +532,8 @@ void Term::calculate_coefficient_and_error_on_discretized_data(bool direction_ri`
`532`	`532`	`double xwy{0};`
`533`	`533`	`for (size_t i = index_start; i <= index_end; ++i)`
`534`	`534`	`{`
`535`		`- if(sample_weight_discretized.size()>0)`
`536`		`- {`
`537`		`- xwx+=values_sorted[i]values_sorted[i]sample_weight_discretized[i];`
`538`		`- xwy+=values_sorted[i]y_discretized[i]sample_weight_discretized[i];`
`539`		`- }`
`540`		`- else`
`541`		`- {`
`542`		`- xwx+=values_sorted[i]*values_sorted[i];`
`543`		`- xwy+=values_sorted[i]*y_discretized[i];`
`544`		`- }`
	`535`	`+ xwx+=values_sorted[i]values_sorted[i]sample_weight_discretized[i];`
	`536`	`+ xwy+=values_sorted[i]y_discretized[i]sample_weight_discretized[i];`
`545`	`537`	`}`
`546`	`538`	`if(xwx!=0)`
`547`	`539`	`{`