Skip to content

Commit ab22926

Browse files
renaming of methods
1 parent c562c58 commit ab22926

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

cpp/APLRRegressor.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ void APLRRegressor::determine_interactions_to_consider()
422422
if(!(terms[sorted_latest_split_point_errors_indices[i]]==interaction))
423423
{
424424
interaction.given_terms.push_back(terms[sorted_latest_split_point_errors_indices[i]]);
425-
interaction.given_terms[interaction.given_terms.size()-1].clean_up_when_this_term_was_added_as_a_given_predictor();
425+
interaction.given_terms[interaction.given_terms.size()-1].cleanup_when_this_term_was_added_as_a_given_predictor();
426426
bool already_exists{false};
427427
for (size_t k = 0; k < terms_eligible_current.size(); ++k)
428428
{
@@ -839,7 +839,7 @@ void APLRRegressor::cleanup_after_fit()
839839
error_index_for_interactions_to_consider.resize(0);
840840
for (size_t i = 0; i < terms.size(); ++i)
841841
{
842-
terms[i].clean_up_after_fit();
842+
terms[i].cleanup_after_fit();
843843
}
844844
}
845845

cpp/term.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ class Term
5353
void estimate_split_point_on_discretized_data();
5454
void calculate_coefficient_and_error_on_discretized_data(bool direction_right, double split_point);
5555
void estimate_coefficient_and_error_on_all_data();
56-
void clean_up_after_estimate_split_point();
57-
void clean_up_after_fit();
58-
void clean_up_when_this_term_was_added_as_a_given_predictor();
56+
void cleanup_after_estimate_split_point();
57+
void cleanup_after_fit();
58+
void cleanup_when_this_term_was_added_as_a_given_predictor();
5959

6060
public:
6161
//fields
@@ -173,7 +173,7 @@ void Term::estimate_split_point(const MatrixXd &X,const VectorXd &y,const Vector
173173
discretize_data_by_bin();
174174
estimate_split_point_on_discretized_data();
175175
estimate_coefficient_and_error_on_all_data();
176-
clean_up_after_estimate_split_point();
176+
cleanup_after_estimate_split_point();
177177
}
178178

179179
//Calculate indices that get zeroed out during calculate() because of given terms. Also calculates indices of those observations that do not.
@@ -584,7 +584,7 @@ void Term::estimate_coefficient_and_error_on_all_data()
584584
}
585585
}
586586

587-
void Term::clean_up_after_estimate_split_point()
587+
void Term::cleanup_after_estimate_split_point()
588588
{
589589
given_terms_indices.not_zeroed.resize(0);
590590
given_terms_indices.zeroed.resize(0);
@@ -595,7 +595,7 @@ void Term::clean_up_after_estimate_split_point()
595595
errors_initial.resize(0);
596596
}
597597

598-
void Term::clean_up_after_fit()
598+
void Term::cleanup_after_fit()
599599
{
600600
bins_start_index.clear();
601601
bins_end_index.clear();
@@ -605,9 +605,9 @@ void Term::clean_up_after_fit()
605605
sample_weight_discretized.resize(0);
606606
}
607607

608-
void Term::clean_up_when_this_term_was_added_as_a_given_predictor()
608+
void Term::cleanup_when_this_term_was_added_as_a_given_predictor()
609609
{
610-
clean_up_after_fit();
610+
cleanup_after_fit();
611611
coefficient_steps.resize(0);
612612
}
613613

0 commit comments

Comments
 (0)