bugfix related to group validation mse

mathias-von-ottenbreit · mathias-von-ottenbreit · commit b8068ae874ad · 2022-12-24T12:21:17.000+01:00
diff --git a/cpp/APLRRegressor.h b/cpp/APLRRegressor.h
@@ -944,6 +944,7 @@ void APLRRegressor::revert_scaling_if_using_log_link_function()
     if(link_function=="log")
     {
         intercept+=std::log(1/scaling_factor_for_log_link_function);
+        y_validation/=scaling_factor_for_log_link_function;
     }
 }
 
diff --git a/setup.py b/setup.py
@@ -15,7 +15,7 @@
 
 setuptools.setup(
     name='aplr',
-    version='1.7.0',
+    version='1.7.1',
     description='Automatic Piecewise Linear Regression',
     ext_modules=[sfc_module],
     author="Mathias von Ottenbreit",

Original file line number	Diff line number	Diff line change
`@@ -944,6 +944,7 @@ void APLRRegressor::revert_scaling_if_using_log_link_function()`
`944`	`944`	`if(link_function=="log")`
`945`	`945`	`{`
`946`	`946`	`intercept+=std::log(1/scaling_factor_for_log_link_function);`
	`947`	`+ y_validation/=scaling_factor_for_log_link_function;`
`947`	`948`	`}`
`948`	`949`	`}`
`949`	`950`