fixed intercept_steps bug

mathias-von-ottenbreit · mathias-von-ottenbreit · commit c278a3618ae0 · 2023-01-10T11:21:31.000+01:00
diff --git a/cpp/APLRRegressor.h b/cpp/APLRRegressor.h
@@ -943,9 +943,13 @@ void APLRRegressor::revert_scaling_if_using_log_link_function()
 {
     if(link_function=="log")
     {
-        intercept+=std::log(1/scaling_factor_for_log_link_function);
         y_train/=scaling_factor_for_log_link_function;
         y_validation/=scaling_factor_for_log_link_function;
+        intercept+=std::log(1/scaling_factor_for_log_link_function);
+        for (size_t i = 0; i < static_cast<size_t>(intercept_steps.size()); ++i)
+        {
+            intercept_steps[i]+=std::log(1/scaling_factor_for_log_link_function);
+        }
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -943,9 +943,13 @@ void APLRRegressor::revert_scaling_if_using_log_link_function()`
`943`	`943`	`{`
`944`	`944`	`if(link_function=="log")`
`945`	`945`	`{`
`946`		`- intercept+=std::log(1/scaling_factor_for_log_link_function);`
`947`	`946`	`y_train/=scaling_factor_for_log_link_function;`
`948`	`947`	`y_validation/=scaling_factor_for_log_link_function;`
	`948`	`+ intercept+=std::log(1/scaling_factor_for_log_link_function);`
	`949`	`+ for (size_t i = 0; i < static_cast<size_t>(intercept_steps.size()); ++i)`
	`950`	`+ {`
	`951`	`+ intercept_steps[i]+=std::log(1/scaling_factor_for_log_link_function);`
	`952`	`+ }`
`949`	`953`	`}`
`950`	`954`	`}`
`951`	`955`