bugfix

Author: mathias-von-ottenbreit

cpp/APLRRegressor.h

@@ -1134,15 +1134,10 @@ VectorXd APLRRegressor::calculate_neg_gradient_current()
 VectorXd APLRRegressor::calculate_neg_gradient_current_for_group_mse(GroupData &group_residuals_and_count, const VectorXi &group,
                                                                      const std::set<int> &unique_groups)
 {
-    for (int unique_group_value : unique_groups)
-    {
-        group_residuals_and_count.error[unique_group_value] /= group_residuals_and_count.count[unique_group_value];
-    }
-
     VectorXd output{VectorXd(y_train.rows())};
     for (Eigen::Index i = 0; i < y_train.size(); ++i)
     {
-        output[i] = group_residuals_and_count.error[group[i]] * sample_weight_train[i];
+        output[i] = group_residuals_and_count.error[group[i]];
     }
 
     return output;

cpp/tests.cpp

@@ -952,7 +952,7 @@ class Tests
         save_as_csv_file("data/output.csv", predictions);
 
         std::cout << predictions.mean() << "\n\n";
-        tests.push_back(is_approximately_equal(predictions.mean(), 20.849747430496922));
+        tests.push_back(is_approximately_equal(predictions.mean(), 23.900212415566287));
     }
 
     void test_aplrregressor_group_mse_cycle()
@@ -995,7 +995,7 @@ class Tests
         save_as_csv_file("data/output.csv", predictions);
 
         std::cout << predictions.mean() << "\n\n";
-        tests.push_back(is_approximately_equal(predictions.mean(), 23.529085584946195));
+        tests.push_back(is_approximately_equal(predictions.mean(), 24.014522054509584));
     }
 
     void test_aplrregressor_int_constr()

documentation/APLR 10.7.2.pdf renamed to documentation/APLR 10.7.3.pdf

@@ -27,7 +27,7 @@
 
 setuptools.setup(
     name="aplr",
-    version="10.7.2",
+    version="10.7.3",
     description="Automatic Piecewise Linear Regression",
     ext_modules=[sfc_module],
     author="Mathias von Ottenbreit",