Skip to content

Commit fad523a

Browse files
err validation wip
1 parent 8ae5f9e commit fad523a

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

cpp/APLRRegressor.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -735,10 +735,9 @@ void APLRRegressor::select_the_best_term_and_update_errors(size_t boosting_step)
735735
}
736736

737737
validation_error_steps[boosting_step]=calculate_mean_error(calculate_errors(y_validation,predictions_current_validation,sample_weight_validation,family,tweedie_power),sample_weight_validation);
738-
bool validation_error_is_invalid{std::isless(validation_error_steps[boosting_step],0) || !std::isfinite(validation_error_steps[boosting_step]) || std::isnan(validation_error_steps[boosting_step])};
738+
bool validation_error_is_invalid{std::isinf(validation_error_steps[boosting_step])};
739739
if(validation_error_is_invalid)
740740
{
741-
validation_error_steps[boosting_step]=std::numeric_limits<double>::infinity();
742741
abort_boosting=true;
743742
std::string warning_message{"Warning: Encountered numerical problems when calculating prediction errors in the previous boosting step. Not continuing with further boosting steps."};
744743
bool show_additional_warning{family=="poisson" || family=="tweedie" || family=="gamma" || (link_function!="identity" && link_function!="logit")};

0 commit comments

Comments
 (0)