Fix bug where reporting network policies from a namespace without any policies could cause an error (#289)

Author: omris94

src/mapper/pkg/networkpolicyreport/network_policies_reconciler.go

@@ -52,7 +52,7 @@ func (r *NetworkPolicyReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 }
 
 func (r *NetworkPolicyReconciler) convertToNetworkPolicyInputs(netpols []networkingv1.NetworkPolicy) ([]cloudclient.NetworkPolicyInput, error) {
-	var netpolsToReport []cloudclient.NetworkPolicyInput
+	netpolsToReport := make([]cloudclient.NetworkPolicyInput, 0)
 	for _, netpol := range netpols {
 		netpolToReport, err := r.convertToNetworkPolicyInput(netpol)
 		if err != nil {

src/mapper/pkg/networkpolicyreport/network_policy_reconciler_test.go

@@ -82,6 +82,16 @@ func (s *NetworkPolicyReconcilerTestSuite) TestNetworkPolicyUpload() {
 	s.True(res.IsZero())
 }
 
+func (s *NetworkPolicyReconcilerTestSuite) TestNetworkPolicyUpload_EmptyNamespace() {
+	emptyList := networkingv1.NetworkPolicyList{}
+	s.k8sClient.EXPECT().List(gomock.Any(), gomock.Eq(&emptyList), gomock.Eq(client.InNamespace("test-namespace"))).Return(nil)
+	s.cloudClient.EXPECT().ReportNetworkPolicies(gomock.Any(), "test-namespace", gomock.Eq(make([]cloudclient.NetworkPolicyInput, 0))).Return(nil)
+
+	res, err := s.reconciler.Reconcile(context.Background(), ctrl.Request{NamespacedName: types.NamespacedName{Name: "test-networkpolicy", Namespace: "test-namespace"}})
+	s.NoError(err)
+	s.True(res.IsZero())
+}
+
 func TestNetworkPolicyReconcilerTestSuite(t *testing.T) {
 	suite.Run(t, new(NetworkPolicyReconcilerTestSuite))
 }