AO3-7231 Upgrade gems and configs to Rails 8.0.x #5515
Conversation
Looked at all uses of to_time: * used for duration (difference, so zone vs offset doesn't matter) * stored in model/DB (rails converts to UTC) * read from model and sent to akismet (rails converts to UTC) * or just forced to utc strict_freshness: I don't see any issues arising from it Regexp.timeout: in my mind, 1s should be sufficient
better safe than sorry?
There was a problem hiding this comment.
Upgrade script wanted puma.rb, but I ignored it per this comment.
It also wanted to set silence_healthcheck_path in production.rb but it doesn't look like we're using the system anyways. (Noting this just in case we want something silenced, but I doubt it.)
|
|
||
| # Library for helping run pt-online-schema-change commands: | ||
| gem "departure", "~> 6.8" | ||
| gem "departure", "~> 8.0" |
There was a problem hiding this comment.
Didn't see anything of note in the changelog. Note that 8.0.1 seems to have not been published to rubygems (if it does get published I would like to pull it in).
|
|
||
| group :test do | ||
| gem "rspec-rails", "~> 6.0" | ||
| gem "rspec-rails", "~> 8.0" |
| # Raise exceptions for disallowed deprecations. | ||
| config.active_support.disallowed_deprecation = :raise | ||
|
|
||
| # Tell Active Support which deprecation messages to disallow. | ||
| config.active_support.disallowed_deprecation_warnings = [] | ||
|
|
There was a problem hiding this comment.
Removed from example config, we're not using it anyways.
There was a problem hiding this comment.
Not sure if this file is needed since the app should be able to respond itself.
There was a problem hiding this comment.
These get copied to the Nginx proxy/frontend servers, so if memory serves, they can respond with this rather than going to the backend for it
The setting will be undeprecated and enabled by default in Rails 8.2 https://redirect.github.com/rails/rails/commit/a477a3273c3c71305cc8ae1835638dc75184ad9d
brianjaustin
left a comment
brianjaustin
left a comment
There was a problem hiding this comment.
Some minor things, and I'd like to see testing steps in the ticket before approving. Looks good, generally, though!
There was a problem hiding this comment.
These get copied to the Nginx proxy/frontend servers, so if memory serves, they can respond with this rather than going to the backend for it
the only thing that is different is trailing newlines - looks like it was done in otwcode#5277
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
4 participants
Issue
https://otwarchive.atlassian.net/browse/AO3-7231
Purpose
Upgrade to Rails 8.0.
The upgrade was surprisingly (suspiciously?) straightforward, considering it's a major version bump. I'll add additional notes/comments in a review.
Testing Instructions
TBD, see Jira.
Credit
marcus8448 (he/him)