resolved comments

Author: oursimon

internal/weights/weights.go

@@ -30,7 +30,7 @@ func (w Weights) sum() int {
 	return sum
 }
 
-func (w Weights) absMaxWeight() int {
+func (w Weights) maxWeight() int {
 	maxWeight := 0
 	for _, weight := range w {
 		absWeight := abs(weight)
@@ -43,8 +43,8 @@ func (w Weights) absMaxWeight() int {
 }
 
 func (w Weights) WeightsToLarge() bool {
-	sum := w.sum()
-	tooLarge := abs(sum) > WEIGHTS_SATURATION_LIMIT
+	sum := abs(w.sum())
+	tooLarge := sum > WEIGHTS_SATURATION_LIMIT
 	return tooLarge
 }
 
@@ -67,7 +67,7 @@ func Calculate(
 		notSelectedSum,
 		preferredSum,
 	)
-	maxPeriodWeight := periodWeights.absMaxWeight()
+	maxPeriodWeight := periodWeights.maxWeight()
 
 	selectedWeights := calculateSelectedWeights(
 		selections,

internal/weights/weights_test.go

@@ -241,7 +241,7 @@ func Test_abs(t *testing.T) {
 	}
 }
 
-func Test_Weights_absMaxWeight(t *testing.T) {
+func Test_Weights_maxWeight(t *testing.T) {
 	theories := []struct {
 		weights  Weights
 		expected int
@@ -270,7 +270,7 @@ func Test_Weights_absMaxWeight(t *testing.T) {
 	}
 
 	for _, theory := range theories {
-		actual := theory.weights.absMaxWeight()
+		actual := theory.weights.maxWeight()
 		assert.Equal(t, theory.expected, actual)
 	}
 }
@@ -284,7 +284,7 @@ func Test_absSum(t *testing.T) {
 		{terms: []int{0, 0, 0}, expected: 0},
 		{terms: []int{-1, -2, -3}, expected: 6},
 		{terms: []int{1, 2, 3}, expected: 6},
-		{terms: []int{-1, -2, -3}, expected: 6},
+		{terms: []int{-1, 2, -3}, expected: 6},
 	}
 
 	for _, theory := range theories {
@@ -302,20 +302,20 @@ func Test_calculatePeriodWeights(t *testing.T) {
 		want           Weights
 	}{
 		{
-			name:      "given no periodIDs should return empty Weights",
+			name:      "no periodIDs should return empty Weights",
 			periodIDs: []string{},
 			want:      Weights{},
 		},
 		{
-			name:      "given periodIDs and zero notSelectedSum and preferredSum",
+			name:      "zero notSelectedSum and preferredSum",
 			periodIDs: []string{"a", "b"},
 			want: Weights{
 				"a": 0,
 				"b": -1,
 			},
 		},
 		{
-			name:           "given periodIDs and non-zero positive notSelectedSum",
+			name:           "non-zero positive notSelectedSum",
 			periodIDs:      []string{"a", "b"},
 			notSelectedSum: 1,
 			want: Weights{
@@ -324,7 +324,7 @@ func Test_calculatePeriodWeights(t *testing.T) {
 			},
 		},
 		{
-			name:           "given periodIDs and non-zero negative notSelectedSum",
+			name:           "non-zero negative notSelectedSum",
 			periodIDs:      []string{"a", "b"},
 			notSelectedSum: -1,
 			want: Weights{
@@ -333,7 +333,7 @@ func Test_calculatePeriodWeights(t *testing.T) {
 			},
 		},
 		{
-			name:           "given periodIDs and non-zero preferredSum and notSelectedSum",
+			name:           "non-zero preferredSum and notSelectedSum",
 			periodIDs:      []string{"a", "b"},
 			notSelectedSum: -1,
 			preferredSum:   -2,