Fix self review comments

Author: boscar

puan/ruleset.go

@@ -394,21 +394,25 @@ func (r *Ruleset) assume(id string) error {
 	return r.setAuxiliaryConstraint(constraint)
 }
 
-func (r *Ruleset) isValidTime(timestamp *time.Time) bool {
-	if timestamp == nil {
+func (r *Ruleset) isValidFromTime(from *time.Time) bool {
+	if r.timeDisabled() {
 		return true
 	}
 
-	if len(r.periodVariables) == 0 {
+	if from == nil {
 		return true
 	}
 
 	for _, periodVariable := range r.periodVariables {
-		isBeforeEnd := !timestamp.After(periodVariable.period.To())
-		if isBeforeEnd {
+		isValid := !from.After(periodVariable.period.To())
+		if isValid {
 			return true
 		}
 	}
 
 	return false
 }
+
+func (r *Ruleset) timeDisabled() bool {
+	return len(r.periodVariables) == 0
+}

puan/ruleset_creator.go

@@ -222,7 +222,7 @@ func (c *RulesetCreator) findDependantVariables() []string {
 
 func (c *RulesetCreator) newPeriodVariables() (TimeBoundVariables, error) {
 	if c.timeDisabled() {
-		return TimeBoundVariables{}, nil
+		return nil, nil
 	}
 
 	nonOverlappingPeriods := calculateCompletePeriods(

puan/ruleset_test.go

@@ -374,7 +374,7 @@ func Test_validateVariables_givenUniquePeriod_shouldReturnError(t *testing.T) {
 	assert.Error(t, err)
 }
 
-func Test_RuleSet_isValidTime(t *testing.T) {
+func Test_RuleSet_isValidFromTime(t *testing.T) {
 	timestamp := fake.New[time.Time]()
 	before := timestamp.Add(-1 * time.Hour)
 	after := timestamp.Add(1 * time.Hour)
@@ -445,7 +445,7 @@ func Test_RuleSet_isValidTime(t *testing.T) {
 
 	for _, tt := range cases {
 		t.Run(tt.name, func(t *testing.T) {
-			got := tt.ruleset.isValidTime(tt.timestamp)
+			got := tt.ruleset.isValidFromTime(tt.timestamp)
 			assert.Equal(t, tt.want, got)
 		})
 	}

puan/solution_creator.go

@@ -192,10 +192,10 @@ func updateSolveError(
 ) error {
 	noSolutionFound := errors.Is(err, puanerror.NoSolutionFound)
 	if noSolutionFound {
-		invalidTime := !ruleset.isValidTime(from)
+		invalidTime := !ruleset.isValidFromTime(from)
 		if invalidTime {
 			return errors.Errorf(
-				"%wFrom '%s' is not valid for the ruleset",
+				"%w: from '%s' is not valid for the ruleset",
 				puanerror.InvalidArgument,
 				from,
 			)