Make ports positional arguments

Author: outcatcher

ensure.go

@@ -2,10 +2,10 @@ package main
 
 import (
 	"context"
+	"flag"
 	"fmt"
 	"os"
 	"strconv"
-	"strings"
 	"time"
 
 	"github.com/outcatcher/fwd2me/forwarder"
@@ -18,11 +18,11 @@ var (
 
 // keepForwarded makes sure ports are forwarded as long as possible without using a long lease.
 func keepForwarded(ctx context.Context) error {
-	if *portsStr == "" {
-		return fmt.Errorf("no ports given")
-	}
+	portSlice := flag.Args()
 
-	portSlice := strings.Split(*portsStr, ",")
+	if len(portSlice) == 0 {
+		return fmt.Errorf("empty port list")
+	}
 
 	ports := make([]uint16, 0, len(portSlice))
 

main.go

@@ -10,12 +10,16 @@ import (
 )
 
 var (
-	portsStr = flag.String("ports", "", "Comma-separated list of ports to forward (REQUIRED)")
-	proto    = flag.String("proto", "TCP", "Forwarded port protocol")
-	label    = flag.String("label", "fwd2me", "Label for the forwarding")
+	proto = flag.String("proto", "TCP", "Forwarded port protocol")
+	label = flag.String("label", "fwd2me", "Label for the forwarding")
 )
 
 func main() {
+	flag.Usage = func() {
+		fmt.Fprintf(flag.CommandLine.Output(), "Usage of %s [options] [port1 port2 ...]:\n", os.Args[0])
+		flag.PrintDefaults()
+	}
+
 	flag.Parse()
 
 	ctx, cancel := context.WithCancel(context.Background())