Add tests for action handlers (#11)

Add tests for action handlers

Update dependencies

Author: outcatcher

.mockery.yaml

@@ -4,8 +4,10 @@ recursive: false
 dir: "{{.InterfaceDir}}/mocks"
 outpkg: "mocks"
 filename: "mock_{{.InterfaceName}}.go"
+mock-build-tags: "test"
 packages:
   github.com/outcatcher/hipapu/app:
+  github.com/outcatcher/hipapu/cmd/handlers:
 
 # compatibility warnings
 issue-845-fix: true

Taskfile.yaml

@@ -14,7 +14,7 @@ tasks:
 
   mock:
     desc: Generates mocks
-    cmd: docker run -v "$PWD":/src -w /src vektra/mockery
+    cmd: docker run -v "$PWD":/src -w /src vektra/mockery:v2.53
 
   test:
     desc: Run tests
@@ -27,4 +27,4 @@ tasks:
 
   build:
     desc: Build binary
-    cmd: go build -o ./build/hihapu ./cmd/main.go
+    cmd: go build -o ./build/hipapu ./cmd/main.go

app/mocks/mock_cfg.go

@@ -1,10 +1,39 @@
 // Copyright (C) 2025  Anton Kachurin
 package handlers
 
+import (
+	"context"
+	"fmt"
+
+	"github.com/outcatcher/hipapu/app"
+	"github.com/outcatcher/hipapu/internal/config"
+	"github.com/urfave/cli/v3"
+)
+
 // DefaultCommandName - name of default command.
 const DefaultCommandName = commandNameList
 
+type application interface {
+	List() []config.Installation
+	Add(remoteURL, localPath string) error
+	Synchronize(ctx context.Context) error
+}
+
 // ActionHandlers handle CLI actions.
 type ActionHandlers struct {
 	filePath, repoPath, configPath string
+
+	app application
+}
+
+// Before is a before function for the command handlers.
+func (h *ActionHandlers) Before(ctx context.Context, _ *cli.Command) (context.Context, error) {
+	application, err := app.New(h.configPath)
+	if err != nil {
+		return ctx, fmt.Errorf("failed to init app: %w", err)
+	}
+
+	h.app = application
+
+	return ctx, nil
 }

app/mocks/mock_localFiles.go

@@ -5,14 +5,13 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/outcatcher/hipapu/app"
 	"github.com/urfave/cli/v3"
 )
 
 const commandNameAdd = "add"
 
-// AddCommand handle 'add' subcommand.
-func (h *ActionHandlers) AddCommand() *cli.Command {
+// CommandAdd handle 'add' subcommand.
+func (h *ActionHandlers) CommandAdd() *cli.Command {
 	return &cli.Command{
 		Name:  commandNameAdd,
 		Usage: "Adds package to the watchlist",
@@ -42,17 +41,12 @@ func (h *ActionHandlers) AddCommand() *cli.Command {
 	}
 }
 
-func (h *ActionHandlers) addHandler(context.Context, *cli.Command) error {
-	application, err := app.New(h.configPath)
-	if err != nil {
-		return fmt.Errorf("failed to start app: %w", err)
-	}
-
-	if err := application.Add(h.repoPath, h.filePath); err != nil {
+func (h *ActionHandlers) addHandler(_ context.Context, cmd *cli.Command) error {
+	if err := h.app.Add(h.repoPath, h.filePath); err != nil {
 		return fmt.Errorf("error during installation addition: %w", err)
 	}
 
-	println("Added!")
+	_, _ = fmt.Fprintln(cmd.Writer, "Added!")
 
 	return nil
 }

app/mocks/mock_remoteClient.go

@@ -0,0 +1,40 @@
+// Copyright (C) 2025  Anton Kachurin
+
+//go:build test
+// +build test
+
+package handlers //nolint:testpackage  // don't want to make useless tests overly complex
+
+import (
+	"io"
+	"testing"
+
+	"github.com/outcatcher/hipapu/cmd/handlers/mocks"
+	"github.com/stretchr/testify/require"
+)
+
+func TestAdd(t *testing.T) {
+	t.Parallel()
+
+	ctx := t.Context()
+
+	const (
+		expectedFilePath = "test-file-path-add"
+		expectedRepoPath = "test-repo-path-add"
+	)
+
+	appMock := mocks.NewMockapplication(t)
+	appMock.On("Add", expectedRepoPath, expectedFilePath).Once().Return(nil)
+
+	hdl := &ActionHandlers{
+		filePath:   expectedFilePath,
+		repoPath:   expectedRepoPath,
+		configPath: "test-config-path-add",
+		app:        appMock,
+	}
+
+	addCmd := hdl.CommandAdd()
+	addCmd.Writer = io.Discard
+
+	require.NoError(t, addCmd.Action(ctx, addCmd))
+}

cmd/handlers/actions.go

@@ -1,3 +1,5 @@
+// Copyright (C) 2025  Anton Kachurin
+
 package handlers
 
 import (
@@ -6,8 +8,8 @@ import (
 	"github.com/urfave/cli/v3"
 )
 
-// ConfigFlag - handle '--config' flag.
-func (h *ActionHandlers) ConfigFlag() *cli.StringFlag {
+// FlagConfig - handle '--config' flag.
+func (h *ActionHandlers) FlagConfig() *cli.StringFlag {
 	return &cli.StringFlag{
 		Name:        "config",
 		Usage:       "Configuration file path",
@@ -16,8 +18,6 @@ func (h *ActionHandlers) ConfigFlag() *cli.StringFlag {
 		Value:       defaultConfigPath(),
 		Destination: &h.configPath,
 		Aliases:     []string{"c"},
-		TakesFile:   true,
-		OnlyOnce:    true,
 	}
 }
 

cmd/handlers/add.go

@@ -0,0 +1,24 @@
+// Copyright (C) 2025  Anton Kachurin
+
+//go:build test
+// +build test
+
+package handlers //nolint:testpackage  // don't want to make useless tests overly complex
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestConfig(t *testing.T) {
+	t.Parallel()
+
+	const expectedConfigPath = "test-config-path-add"
+
+	hdl := &ActionHandlers{}
+
+	require.NoError(t, hdl.FlagConfig().Set("", expectedConfigPath))
+
+	require.Equal(t, expectedConfigPath, hdl.configPath)
+}